Skip to content

Minor cleanup

Minor cleanup #882

GitHub Actions / Xcode test results succeeded Oct 10, 2023 in 0s

Xcode test results

Testing workspace Proton with scheme Proton

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
3503500002.52s

Test Summary

ProtonTests

  • Device: iPhone 14 Pro, 16.4 (20E247)
  • SDK: Simulator - iOS 16.4, 16.4
TestTotalSuccessFailureSkippedExpected Failure
test-class AsyncTextResolverSnapshotTests33000
test-class AttachmentUpdateSnapshotTests66000
test-class AttributesCommandTests22000
test-class AutogrowingTextViewSnapshotTests22000
test-class AutogrowingTextViewTests11000
test-class EditorCommandExecutorTests55000
test-class EditorCommandSnapshotTests11000
test-class EditorContentTransformerTests11000
test-class EditorContextDelegateTests44000
test-class EditorKeyTests77000
test-class EditorListsSnapshotTests3131000
test-class EditorSnapshotTests4343000
test-class EditorViewContextSnapshotTests11000
test-class EditorViewContextTests55000
test-class EditorViewDelegateTests88000
test-class EditorViewMenuTests88000
test-class EditorViewTests4747000
test-class FontTraitToggleCommandTests44000
test-class GridTests1919000
test-class GridViewAttachmentSnapshotTests3939000
test-class GridViewSnapshotTests33000
test-class GridViewTests55000
test-class ListCommandTests22000
test-class ListParserTests1111000
test-class ListsSnapshotTests44000
test-class NSAttributedStringExtensionTests1717000
test-class RichTextViewContextTests1212000
test-class RichTextViewSnapshotTests33000
test-class RichTextViewTests1010000
test-class TextBlockAttributeTests2121000
test-class TextProcessorTests1313000
test-class TextStorageTests66000
test-class ViewAttachmentSnapshotTests66000

Failure Failures

All tests passed 🎉


Code Coverage

Coverage Covered Executable
Proton.framework 82.02 % 4868 5935
  Grid.swift 90.93 % 321 353
  NSParagraphStyleExtensions.swift 87.50 % 7 8
  SequenceGenerator.swift 78.26 % 18 23
  TextProcessor.swift 100.00 % 66 66
  EditorView.swift 76.29 % 682 894
  AutogrowingTextView.swift 81.25 % 65 80
  NSAttributedString+Range.swift 93.88 % 92 98
  GestureRegognizerDelegateOverride.swift 6.52 % 3 46
  GridCell.swift 83.33 % 150 180
  UnderlineCommand.swift 100.00 % 4 4
  AttachmentContent.swift 71.43 % 10 14
  AsyncTaskScheduler.swift 98.59 % 70 71
  TextProcessing.swift 20.00 % 1 5
  UIColor+Image.swift 100.00 % 10 10
  EditorContentView.swift 44.44 % 8 18
  NSRangeExtensions.swift 69.44 % 25 36
  AttributesDecoding.swift 0.00 % 0 8
  AttributesToggleCommand.swift 98.21 % 55 56
  Attachment.swift 88.06 % 317 360
  FontTraitToggleCommand.swift 96.77 % 30 31
  LayoutManager.swift 93.39 % 664 711
  EditorContentDecoding.swift 0.00 % 0 7
  RichTextEditorContext.swift 70.05 % 152 217
  EditorContent.swift 63.64 % 7 11
  GridView.swift 60.37 % 227 376
  RichTextViewContext.swift 95.38 % 62 65
  FontExtensions.swift 73.77 % 45 61
  RichTextRendererContext.swift 0.00 % 0 1
  NullRichTextEditorContext.swift 0.00 % 0 6
  EditorContentEncoding.swift 75.00 % 9 12
  RichTextViewDelegate.swift 100.00 % 18 18
  EditorCommandExecutor.swift 100.00 % 11 11
  RichTextView.swift 82.94 % 530 639
  UITextRangeExtensions.swift 100.00 % 5 5
  CommandName.swift 100.00 % 6 6
  AggregateEditorViewDelegate.swift 91.23 % 52 57
  String+NSRange.swift 66.67 % 20 30
  BackgroundStyle.swift 100.00 % 27 27
  NSAttributedString+Content.swift 98.99 % 196 198
  GridCellStore.swift 85.51 % 59 69
  GridConfiguration.swift 100.00 % 43 43
  ListParser.swift 96.35 % 132 137
  BoldCommand.swift 100.00 % 3 3
  ListOutdentCommand.swift 62.50 % 5 8
  StrikethroughCommand.swift 100.00 % 4 4
  EditorViewDelegate.swift 42.86 % 6 14
  EditorCommand.swift 0.00 % 0 5
  ListCommand.swift 92.86 % 65 70
  GridContentView.swift 79.36 % 273 344
  ListIndentCommand.swift 62.50 % 5 8
  SynchronizedArray.swift 61.11 % 33 54
  EditorViewContext.swift 78.57 % 11 14
  ListTextProcessor.swift 81.68 % 214 262
  ItalicsCommand.swift 100.00 % 3 3
  SelectionView.swift 48.94 % 23 47
  AttributesEncoding.swift 78.57 % 11 14
  GradientView.swift 76.47 % 13 17
Total 82.02 % 4868 5935

Details

Test Details

ProtonTestsback

AsyncTextResolverSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.77s
Successtest-method testDiscardsAsyncAttributeInOrder()
Successtest-method testIgnoresTextAsyncAttributeUntilInvoked()
Successtest-method testResolvesAsyncAttributeInOrder()

AttachmentUpdateSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.14s
Successtest-method testRendersImageBasedBlockAttachment()
Successtest-method testRendersImageBasedInlineAttachment()
Successtest-method testRendersUpdatedImageInAttachment()
Successtest-method testRendersUpdatedViewInAttachment()
Successtest-method testRendersUpdatedViewInImageAttachment()
Successtest-method testRenderUpdatedImageInViewAttachment()

AttributesCommandTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testSetsToggledTypingAttributesInEmptySelectionInNonEmptyEditor()
Successtest-method testSetsTypingAttributesInEmptyEditor()

AutogrowingTextViewSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.04s
Successtest-method testRendersMultilineTextViewBasedOnContent()
Successtest-method testRendersTextViewBasedOnContent()

AutogrowingTextViewTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testNotifiesDelegateOfBoundsChange()

EditorCommandExecutorTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)1.01s
Successtest-method testDoesNotExecuteCommandsIfRequiresCommandRegistrationAndNoCommandsRegistered()
Successtest-method testExecuteAllCommandsByDefault()
Successtest-method testExecuteCommandsBasedOnContext()
Successtest-method testExecutesCommandOnEditor()
Successtest-method testExecutesOnlyRegisteredCommandsOnEditor()

EditorCommandSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.07s
Successtest-method testExecutesCommandOnNestedEditors()

EditorContentTransformerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testTransformsText()

EditorContextDelegateTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testDidChangeSelectionInAllEditors()
Successtest-method testDidLoseFocusInAllEditors()
Successtest-method testDidReceiveFocusInAllEditors()
Successtest-method testDidReceiveKeyInAllEditors()

EditorKeyTests back

SuccessFailureSkippedExpected Failure⏱️
7 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method test_ReturnsDown()
Successtest-method test_ReturnsEnter()
Successtest-method test_ReturnsLeft()
Successtest-method test_ReturnsRight()
Successtest-method test_ReturnsTab()
Successtest-method test_ReturnsUp()
Successtest-method testReturnsNil()

EditorListsSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
31 (100%)0 (0%)0 (0%)0 (0%)0.03s
Successtest-method testAddsMultipleLevelOfLists()
Successtest-method testAppliesAndRemovesListStyleToEntireLineOnPartialSelection()
Successtest-method testContinuesNumberingWhenTwoListsAreCombined()
Successtest-method testCreatesListBetweenTwoParagraphs()
Successtest-method testCreatesListFromSelectedText()
Successtest-method testCreatesListWithoutSelectionUsingCommandAtEnd()
Successtest-method testCreatesListWithoutSelectionUsingCommandInBeginning()
Successtest-method testCreatesListWithoutSelectionUsingCommandInTheMiddle()
Successtest-method testCreatesNewListItemOnReturnKey()
Successtest-method testCreatesNewListItemOnSecondReturnKeyWhenInMiddleOfAList()
Successtest-method testExitsNewListItemOnSecondReturnKey()
Successtest-method testExitsNewListItemOnSecondReturnKeyWithTrailingNonListText()
Successtest-method testFullWidthAttachmentInLists()
Successtest-method testIndentsAndOutdentsListWithMultipleSelectedLines()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInBeginning()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInEnd()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInMiddle()
Successtest-method testIndentsNestedItems()
Successtest-method testInitiatesCreationOfList()
Successtest-method testOutdentsNestedItems()
Successtest-method testOutdentsToZerothLevel()
Successtest-method testQueriesDelegateForListLineMarker()
Successtest-method testRegeneratesNumbersOnChangesToNonListTextInMiddleOfLists()
Successtest-method testRemoveListAttributeFromRange()
Successtest-method testRendersListInArrowFormat()
Successtest-method testRendersListInAttributedString()
Successtest-method testRendersListWithDifferentAttributeValues()
Successtest-method testSkipListMarkerForSkipAttribute()
Successtest-method testSkipNumberingForMultilineText()
Successtest-method testSkipsListMarkerOnShiftReturnKeyAtEndOfTheList()
Successtest-method testSkipsListMarkerOnShiftReturnKeyInMiddleOfList()

EditorSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
43 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testBackgroundStyleThreeLines()
Successtest-method testBackgroundStyleTwoLinesMinorOverlap()
Successtest-method testBackgroundStyleTwoLinesNoOverlap()
Successtest-method testBackgroundStyleTwoLinesOverlap()
Successtest-method testBackgroundStyleWithBorders()
Successtest-method testBackgroundStyleWithCapsuleStyle()
Successtest-method testBackgroundStyleWithContinuity()
Successtest-method testBackgroundStyleWithHeightMatchingText()
Successtest-method testBackgroundStyleWithIncreasedFontSize()
Successtest-method testBackgroundStyleWithIncreasedParagraphSpacing()
Successtest-method testBackgroundStyleWithInsets()
Successtest-method testBackgroundStyleWithOverlappingLine()
Successtest-method testBackgroundStyleWithOverlappingLineExactTextHeight()
Successtest-method testBackgroundStyleWithOverlappingLineNoBorder()
Successtest-method testBackgroundStyleWithTextContainerInsets()
Successtest-method testBackgroundStyleWithVariedFontSizes()
Successtest-method testBackgroundStyleWithWidthModeAsText()
Successtest-method testCursorCaretRect()
Successtest-method testDefaultBackground()
Successtest-method testDeletesAttachments()
Successtest-method testEditorWithArabicText()
Successtest-method testGetsCaretRectForPositionInEmptyEditor()
Successtest-method testGetsCaretRectForPositionOutsideBounds()
Successtest-method testGetsCaretRectForValidPosition()
Successtest-method testGetsCaretRectForValidPositionWithScrollableContent()
Successtest-method testGetsCurrentLineRange()
Successtest-method testGetsRectsForGivenRangeSpanningAcrossMultipleLines()
Successtest-method testGetsRectsForGivenRangeSpanningAcrossSingleLine()
Successtest-method testGetsVisibleContentRange()
Successtest-method testLineRanges()
Successtest-method testParagraphStyling()
Successtest-method testRendersAsyncAttachments()
Successtest-method testRendersAttachmentWithTextContainerInset()
Successtest-method testRendersFixedWidthAttachment()
Successtest-method testRendersFullWidthAttachment()
Successtest-method testRendersFullWidthAttachmentWithParaIndent()
Successtest-method testRendersMatchContentAttachment()
Successtest-method testRendersPercentWidthAttachment()
Successtest-method testRendersPlaceholder()
Successtest-method testRendersWidthRangeAttachment()
Successtest-method testSelectionRects()
Successtest-method testSuccessiveSimilarBackgroundStyles()
Successtest-method testUpdatesPlaceholderWithInsets()

EditorViewContextSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.02s
Successtest-method testSelectsBeforeDeletingImageBasedAttachment()

EditorViewContextTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testAppliesSameContextAsParentToNestedEditor()
Successtest-method testCarriesOverCustomTypingAttributes()
Successtest-method testGetsActiveEditorViewAcrossMultipleContexts()
Successtest-method testGetsActiveEditorViewFromContext()
Successtest-method testLockedAttributes()

EditorViewDelegateTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testDidChangeSelection()
Successtest-method testDidLoseFocus()
Successtest-method testDidReceiveFocus()
Successtest-method testDidReceiveKey()
Successtest-method testNotifiesBackspace()
Successtest-method testNotifiesEnter()
Successtest-method testNotifiesTab()
Successtest-method testShouldHandleKey()

EditorViewMenuTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testDefaultSelectAll()
Successtest-method testOverridesCopy()
Successtest-method testOverridesCut()
Successtest-method testOverridesPaste()
Successtest-method testOverridesSelect()
Successtest-method testOverridesToggleBold()
Successtest-method testOverridesToggleItalics()
Successtest-method testOverridesToggleUnderline()

EditorViewTests back

SuccessFailureSkippedExpected Failure⏱️
47 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCaretRect()
Successtest-method testGetsAttachmentContentEditors()
Success