Skip to content

Fixed issue where selectedEditorView may be unintentionally updated o… #1504

Fixed issue where selectedEditorView may be unintentionally updated o…

Fixed issue where selectedEditorView may be unintentionally updated o… #1504

GitHub Actions / Xcode test results succeeded Oct 4, 2024 in 0s

Xcode test results

Testing workspace Proton with scheme Proton

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
46646600010.62s

Test Summary

ProtonTests

  • Device: iPhone 15 Pro, 17.2 (21C62)
  • SDK: Simulator - iOS 17.2, 17.2
TestTotalSuccessFailureSkippedExpected Failure
test-class AttachmentUpdateSnapshotTests66000
test-class AttributesCommandTests22000
test-class AutogrowingTextViewSnapshotTests22000
test-class AutogrowingTextViewTests11000
test-class EditorCommandExecutorTests66000
test-class EditorCommandSnapshotTests11000
test-class EditorContentTransformerTests11000
test-class EditorContextDelegateTests44000
test-class EditorKeyTests33000
test-class EditorListsSnapshotTests3232000
test-class EditorSnapshotTests5353000
test-class EditorViewContextSnapshotTests11000
test-class EditorViewContextTests55000
test-class EditorViewDelegateTests88000
test-class EditorViewMenuTests88000
test-class EditorViewTests5555000
test-class ProtonTests.xctest00000
test-class FontTraitToggleCommandTests44000
test-class GridCellTests11000
test-class GridTests2020000
test-class GridViewAttachmentSnapshotTests4747000
test-class GridViewSnapshotTests33000
test-class GridViewTests1111000
test-class ListCommandTests22000
test-class ListParserTests1414000
test-class ListsSnapshotTests44000
test-class NSAttributedStringExtensionTests2727000
test-class RichTextViewContextTests1515000
test-class RichTextViewSnapshotTests33000
test-class RichTextViewTests1212000
test-class TableTests11000
test-class TableViewAttachmentSnapshotTests3939000
test-class TableViewTests22000
test-class TextBlockAttributeTests2323000
test-class TextProcessorTests2525000
test-class TextStorageTests1515000
test-class ViewAttachmentSnapshotTests1010000

Failure Failures

All tests passed 🎉


Code Coverage

Coverage Covered Executable
Proton.framework 77.26 % 7019 9085
  GradientView.swift 76.47 % 13 17
  NSParagraphStyleExtensions.swift 90.00 % 9 10
  EditorView.swift 67.29 % 718 1067
  TextProcessor.swift 100.00 % 102 102
  AutogrowingTextView.swift 81.71 % 67 82
  NSAttributedString+Range.swift 88.03 % 125 142
  GridCell.swift 82.99 % 200 241
  GestureRegognizerDelegateOverride.swift 7.14 % 3 42
  UnderlineCommand.swift 100.00 % 4 4
  AttachmentContent.swift 65.52 % 19 29
  TextProcessing.swift 28.57 % 2 7
  AsyncTaskScheduler.swift 61.18 % 52 85
  UIColor+Image.swift 100.00 % 10 10
  EditorContentView.swift 44.44 % 8 18
  NSRangeExtensions.swift 80.43 % 37 46
  AttributesDecoding.swift 0.00 % 0 8
  AttributesToggleCommand.swift 98.21 % 55 56
  Attachment.swift 85.51 % 419 490
  Table.swift 66.29 % 295 445
  FontTraitToggleCommand.swift 96.77 % 30 31
  TableCellContentView.swift 71.32 % 97 136
  TableCellStore.swift 77.94 % 53 68
  LayoutManager.swift 91.83 % 764 832
  TableContentView.swift 65.06 % 352 541
  EditorContentDecoding.swift 0.00 % 0 7
  RichTextEditorContext.swift 73.42 % 163 222
  LineNumberFormatting.swift 100.00 % 11 11
  GridView.swift 63.41 % 253 399
  EditorContent.swift 63.64 % 7 11
  RichTextViewContext.swift 94.44 % 68 72
  FontExtensions.swift 73.77 % 45 61
  Utility.swift 95.00 % 19 20
  RichTextRendererContext.swift 0.00 % 0 1
  TableCell.swift 78.36 % 105 134
  NullRichTextEditorContext.swift 0.00 % 0 6
  EditorContentEncoding.swift 75.00 % 9 12
  RichTextViewDelegate.swift 85.29 % 29 34
  EditorCommandExecutor.swift 100.00 % 12 12
  ListFormattingProvider.swift 100.00 % 1 1
  RichTextView.swift 85.77 % 699 815
  UITextRangeExtensions.swift 100.00 % 5 5
  CommandName.swift 100.00 % 6 6
  BackgroundStyle.swift 100.00 % 27 27
  AggregateEditorViewDelegate.swift 83.12 % 64 77
  TableView.swift 56.59 % 352 622
  GridConfiguration.swift 100.00 % 75 75
  TableCellRepository.swift 100.00 % 13 13
  NSAttributedString+Content.swift 99.18 % 242 244
  GridCellStore.swift 85.51 % 59 69
  ListParser.swift 94.44 % 170 180
  StrikethroughCommand.swift 100.00 % 4 4
  ListOutdentCommand.swift 62.50 % 5 8
  String+NSRange.swift 66.67 % 20 30
  BoldCommand.swift 100.00 % 3 3
  ListIndentCommand.swift 62.50 % 5 8
  EditorViewDelegate.swift 28.57 % 6 21
  ListCommand.swift 95.80 % 114 119
  GridContentView.swift 78.97 % 308 390
  EditorCommand.swift 0.00 % 0 5
  SynchronizedArray.swift 35.71 % 25 70
  EditorViewContext.swift 78.57 % 11 14
  ListTextProcessor.swift 83.50 % 258 309
  SelectionView.swift 48.94 % 23 47
  ItalicsCommand.swift 100.00 % 3 3
  AttributesEncoding.swift 78.57 % 11 14
  Grid.swift 90.62 % 338 373
  SequenceGenerator.swift 77.27 % 17 22
Total 77.26 % 7019 9085

Details

Test Details

ProtonTestsback

AttachmentUpdateSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.11s
Successtest-method testRendersImageBasedBlockAttachment()
Successtest-method testRendersImageBasedInlineAttachment()
Successtest-method testRendersUpdatedImageInAttachment()
Successtest-method testRendersUpdatedViewInAttachment()
Successtest-method testRendersUpdatedViewInImageAttachment()
Successtest-method testRenderUpdatedImageInViewAttachment()

AttributesCommandTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testSetsToggledTypingAttributesInEmptySelectionInNonEmptyEditor()
Successtest-method testSetsTypingAttributesInEmptyEditor()

AutogrowingTextViewSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.05s
Successtest-method testRendersMultilineTextViewBasedOnContent()
Successtest-method testRendersTextViewBasedOnContent()

AutogrowingTextViewTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.14s
Successtest-method testNotifiesDelegateOfBoundsChange()

EditorCommandExecutorTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)1.02s
Successtest-method testCommandExecutorDelegate()
Successtest-method testDoesNotExecuteCommandsIfRequiresCommandRegistrationAndNoCommandsRegistered()
Successtest-method testExecuteAllCommandsByDefault()
Successtest-method testExecuteCommandsBasedOnContext()
Successtest-method testExecutesCommandOnEditor()
Successtest-method testExecutesOnlyRegisteredCommandsOnEditor()

EditorCommandSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.37s
Successtest-method testExecutesCommandOnNestedEditors()

EditorContentTransformerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testTransformsText()

EditorContextDelegateTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testDidChangeSelectionInAllEditors()
Successtest-method testDidLoseFocusInAllEditors()
Successtest-method testDidReceiveFocusInAllEditors()
Successtest-method testDidReceiveKeyInAllEditors()

EditorKeyTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.02s
Successtest-method test_ReturnsEnter()
Successtest-method test_ReturnsTab()
Successtest-method testReturnsNil()

EditorListsSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
32 (100%)0 (0%)0 (0%)0 (0%)0.06s
Successtest-method testAddsMultipleLevelOfLists()
Successtest-method testAppliesAndRemovesListStyleToEntireLineOnPartialSelection()
Successtest-method testContinuesNumberingWhenTwoListsAreCombined()
Successtest-method testCreatesListBetweenTwoParagraphs()
Successtest-method testCreatesListFromSelectedText()
Successtest-method testCreatesListWithoutSelectionUsingCommandAtEnd()
Successtest-method testCreatesListWithoutSelectionUsingCommandInBeginning()
Successtest-method testCreatesListWithoutSelectionUsingCommandInTheMiddle()
Successtest-method testCreatesNewListItemOnReturnKey()
Successtest-method testCreatesNewListItemOnSecondReturnKeyWhenInMiddleOfAList()
Successtest-method testExitsNewListItemOnSecondReturnKey()
Successtest-method testExitsNewListItemOnSecondReturnKeyWithTrailingNonListText()
Successtest-method testFullWidthAttachmentInLists()
Successtest-method testIndentsAndOutdentsListWithMultipleSelectedLines()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInBeginning()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInEnd()
Successtest-method testIndentsAndOutdentsListWithoutSelectedRangeInMiddle()
Successtest-method testIndentsNestedItems()
Successtest-method testInitiatesCreationOfList()
Successtest-method testOutdentsNestedItems()
Successtest-method testOutdentsToZerothLevel()
Successtest-method testQueriesDelegateForListLineMarker()
Successtest-method testRegeneratesNumbersOnChangesToNonListTextInMiddleOfLists()
Successtest-method testRemoveListAttributeFromRange()
Successtest-method testRendersListInArrowFormat()
Successtest-method testRendersListInAttributedString()
Successtest-method testRendersListWithDifferentAttributeValues()
Successtest-method testResetsParagraphStyleOnExitingList()
Successtest-method testSkipListMarkerForSkipAttribute()
Successtest-method testSkipNumberingForMultilineText()
Successtest-method testSkipsListMarkerOnShiftReturnKeyAtEndOfTheList()
Successtest-method testSkipsListMarkerOnShiftReturnKeyInMiddleOfList()

EditorSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
53 (100%)0 (0%)0 (0%)0 (0%)0.34s
Successtest-method testBackgroundStyleThreeLines()
Successtest-method testBackgroundStyleTwoLinesMinorOverlap()
Successtest-method testBackgroundStyleTwoLinesNoOverlap()
Successtest-method testBackgroundStyleTwoLinesOverlap()
Successtest-method testBackgroundStyleWithBorders()
Successtest-method testBackgroundStyleWithCapsuleStyle()
Successtest-method testBackgroundStyleWithContinuity()
Successtest-method testBackgroundStyleWithHeightMatchingText()
Successtest-method testBackgroundStyleWithIncreasedFontSize()
Successtest-method testBackgroundStyleWithIncreasedParagraphSpacing()
Successtest-method testBackgroundStyleWithInsets()
Successtest-method testBackgroundStyleWithOverlappingLine()
Successtest-method testBackgroundStyleWithOverlappingLineExactTextHeight()
Successtest-method testBackgroundStyleWithOverlappingLineNoBorder()
Successtest-method testBackgroundStyleWithParagraphAndLineSpacing()
Successtest-method testBackgroundStyleWithTextContainerInsets()
Successtest-method testBackgroundStyleWithVariedFontSizes()
Successtest-method testBackgroundStyleWithWidthModeAsText()
Successtest-method testCursorCaretRect()
Successtest-method testCustomLineNumbersWithWrappedText()
Successtest-method testDefaultBackground()
Successtest-method testDeletesAttachments()
Successtest-method testEditorWithArabicText()
Successtest-method testGetsCaretRectForPositionInEmptyEditor()
Successtest-method testGetsCaretRectForPositionOutsideBounds()
Successtest-method testGetsCaretRectForValidPosition()
Successtest-method testGetsCaretRectForValidPositionWithScrollableContent()
Successtest-method testGetsCurrentLineRange()
Successtest-method testGetsRectsForGivenRangeSpanningAcrossMultipleLines()
Successtest-method testGetsRectsForGivenRangeSpanningAcrossSingleLine()
Successtest-method testGetsVisibleContentRange()
Successtest-method testInvisibleCharacters()
Successtest-method testLineNumbersBlank()
Successtest-method testLineNumbersDefault()
Successtest-method testLineNumbersEnableDisable()
Successtest-method testLineNumbersWithFormatting()
Successtest-method testLineNumbersWithLineSpacing()
Successtest-method testLineNumbersWithParagraphSpacing()
Successtest-method testLineNumbersWithWrappedText()
Successtest-method testLineRanges()
Successtest-method testParagraphStyling()
Successtest-method testRendersAttachmentWithTextContainerInset()
Successtest-method testRendersFixedWidthAttachment()
Successtest-method testRendersFullWidthAttachment()
Successtest-method testRendersFullWidthAttachmentWithParaIndent()
Successtest-method testRendersMatchContentAttachment()
Successtest-method testRendersPercentWidthAttachment()
Successtest-method testSelectionRects()
Successtest-method testSelectOnTap()
Successtest-method testSelectOnTapInNonEditableEditor()
Successtest-method testSuccessiveSimilarBackgroundStyles()
Successtest-method testUpdatesPlaceholderWithInsets()
Successtest-method testWrappedBackgroundInNestedEditor()

EditorViewContextSnapshotTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.06s
Successtest-method testSelectsBeforeDeletingImageBasedAttachment()

EditorViewContextTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testAppliesSameContextAsParentToNestedEditor()
Successtest-method testCarriesOverCustomTypingAttributes()
Successtest-method testGetsActiveEditorViewAcrossMultipleContexts()
Successtest-method testGetsActiveEditorViewFromContext()
Successtest-method testLockedAttributes()

EditorViewDelegateTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testDidChangeSelection()
Successtest-method testDidLoseFocus()
Successtest-method testDidReceiveFocus()
Successtest-method testDidReceiveKey()
Successtest-method testNotifiesBackspace()
Successtest-method testNotifiesEnter()
Successtest-method testNotifiesTab()
Successtest-method testShouldHandleKey()

EditorViewMenuTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testDefaultSelectAll()
Successtest-method testOverridesCopy()
Successtest-method testOverridesCut()
Successtest-method testOverridesPaste()
Successtest-method testOverridesSelect()
Successtest-method testOverridesToggleBold()
Successtest-method testOverridesToggleItalics()
Successtest-method testOverridesToggleUnderline()

EditorViewTests back

SuccessFailureSkippedExpected Failure⏱️
55 (100%)0 (0%)0 (0%)0 (0%)0.01s
Success<