Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback feature with screenshot and browser information #953

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jinojossy93
Copy link

PLEASE START REVIEWING. I STILL NEED TO DO SOME MORE REFACTORING. THIS PR IS RAISED FOR SUGGESTIONS ON THE CURRENT IMPLEMENTATION

Issue Reference

This PR addresses the Issue : Fixes #

Issue in /dmodash. Breaking dev environment due to empty medical request count.
Issue in dev environment throwing AWS access key invalid error trying to access AWS from dev environment.

Summarize

Please, describe what the PR does, the changes you have made.

Also, mention the key points if any to look into while code reviews

Modified the sms_handler to have configurable confirmation messages.
Added the feedback feature which will be available in all the screens. See the following screens for the usage and UI changes.

In Mobile UI
image
In Web UI
image

Usage

Click on the Feedback button on the right side
image

Enter phone and feedback and click Next

You can chose Highlight/ Blackout. The first one will highlight the selected region while the other can blackout that portion. Refer the screen shots.
Double click on the screen and drag the pointer to select an area.
image
image

Once you are completed with that click next. This screen will show the whole data that's going to be submitted. Please review and click submit.
image

The entered phone will receive a message. Feedback will be registered and will be available in admin dashboard. Along with feedback we'll also collect browser info and current user URL.

@jinojossy93
Copy link
Author

Hi @biswaz, @bobinson,

Could you please take a look at this. It will work fine in web browsers.
@biswaz as per your suggestion I've added phone number based confirmation message. But since I didn't had a redis server setup in my dev it's not working. But it should work just fine.

Guys,
I know you both are pretty occupied with ongoing ushahidi integration. Please have a look and respond whenever you can.

@dauntlessnomad dauntlessnomad requested review from biswaz and vigneshhari and removed request for biswaz August 27, 2018 09:07
@jinojossy93
Copy link
Author

jinojossy93 commented Aug 27, 2018

Hi @everyone,

Please don't merge this.

This needs some style changes and will be integrated soon. I know it won't happen like that. I'm just saying this so that this won't happen.

@biswaz biswaz added enhancement New feature or request Testing required labels Aug 29, 2018
@biswaz biswaz changed the title [new_feature] Provision for feedback with screenshot and browser information Feedback feature with screenshot and browser information Aug 29, 2018
@biswaz
Copy link

biswaz commented Aug 29, 2018

@jinojossy93 Awesome work Jino!
I can't see the feedbacks from admin. Is it not getting saved properly?
Also keep in mind that people may need to submit non webpage related feedbacks - considering the future aspects of KR - in case this becomes a go to platform for disaster management

@jinojossy93
Copy link
Author

Hi @biswaz ,

Currently, when feedbacks are saved, an error in the redis_worker is happening.

This happens since I've integrated the automated message sending using Redis queue. But I'm not able to run that in my dev environment.

I've used the command that you provided

python3 redis_worker.py

It's throwing an error

python3.6/site-packages/redis/connection.py", line 838, in from_url
if '?' in url.path and not url.query: TypeError: a bytes-like object is required, not 'str'

Please suggest if I missed something for running redis_worker.

Also, I've made the redis_queue message configurable with confirmation_message. Hope that's fine.

Even though it's throwing error.

The feedbacks would be saved here => http://localhost:8000/admin/feedback/feedback/

Please see the feedback's that was uploaded to my other machine which only had the rescuekerala cloned first then. Ran the steps to test a new PR.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Testing required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants