Change CWriter's Converter to an Assoc Type #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTypeConverter doesn't follow the same pattern as the CWriter (implementing a trait of mostly default fns) making it very difficult to alter the functionality of. In addition, CWriter itself uses a static Converter type, disallowing altering it at all.
This pr changes the Converter CWriter uses to an associated type, allowing any type to be used in implementations of CWriter, whether or not they change any other logic.
I was going to do the same for the Python and C# backends, but I noticed their converters didn't implement Traits at all, so I left them alone. I'm happy to do the same for them if this change is favourable.
This is a breaking change of course since implementations of CWriter will need to add the new associated type (something default assoc types would fix 😔).