update(assoc) Simplify Typings to fix inference and cross function usage #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
Harris-Miller
force-pushed
the
assoc-non-breaking-updates
branch
from
7c425ad to
7352edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify typings on
assocTurns out that overloading for the specific key/value scenarios is harder on typescript than returning a complex type checking via ternaries. This works better for pretty much all scenarios. Especially when passing results from curried
assoccalls into other functions, egpipe(assoc('key', 'value'))or[].map(assoc('key', 'value'))See example here: https://tsplay.dev/Na5r0N
Fixes: #35
And: #37 (comment)