Fix(prop): Allow optional props for prop(key)(obj) variety #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
prop(key)(obj)
was typed wasobj extends Record<K, unknown>
. From typescript's point of view, this means that the object must contain the key, but not if the key was optional. The constraint thatprop(key)(obj)
should have is that if the key exists onobj
, optional or not. To fix,Partial<Record<K, unknown>>
should be used. But that's a lot of characters,{ [P in K]?: unknown }
is the exact same thing with less characters, so going with that