-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add username flag for token command #351
base: v2.9
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it looks ok I am wondering about the relation between this new username
and the pre-existing userId
(flag --user
). Is one derivable from the other ?
In our environment there is no relation. It is setup so the |
Does it make sense to support |
Why not support both? The |
@billiford will you add password support as well? maybe name them |
I'd be happy to change this to |
This PR allows us to pass the username as a flag to the
rancher token
command so it does not need to be input each time. This is helpful in Kubernetes configs when defining the login command for a given cluster.Example
$ ranch token --server=my-server --user=my-user --cluster=my-cluster --auth-provider=activeDirectoryProvider --username=my-username Enter credentials for activeDirectoryProvider Enter password:
As we can see it no longer asks for a username if one is passed in.