Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial networking support for shared mode #154

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Initial networking support for shared mode #154

merged 5 commits into from
Dec 10, 2024

Conversation

galal-hussein
Copy link
Collaborator

@galal-hussein galal-hussein commented Nov 29, 2024 •
edited
Loading

The PR does the following:

  • Syncs all the services created in the virtual cluster to the host cluster
  • Creates a coredns service for each virtual cluster
  • In k3k-kubelet, it injects networking information to each pod created including:
    • connection information to the virtual cluster API.
    • DNS information to the coredns service created in the second point.

#116
#140

@galal-hussein galal-hussein changed the title Fix networking in shared mode Initial networking support for shared mode Dec 3, 2024
@galal-hussein galal-hussein marked this pull request as ready for review December 3, 2024 23:16
enrichman
enrichman previously requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. CI is also failing. I have a small PR that should at least fix the tests.

k3k-kubelet/provider/provider.go Outdated Show resolved Hide resolved
k3k-kubelet/controller/service.go Outdated Show resolved Hide resolved
k3k-kubelet/controller/service.go Show resolved Hide resolved
@enrichman enrichman mentioned this pull request Dec 5, 2024
Closed
@enrichman
Copy link
Collaborator

Dismissing the review because I'll be OOO and don't want to block this. :)

briandowns
briandowns reviewed Dec 5, 2024
View reviewed changes
k3k-kubelet/kubelet.go Outdated Show resolved Hide resolved
@galal-hussein
Fixes
9012340 
Signed-off-by: galal-hussein <[email protected]>
@galal-hussein
Fixes
47cee4a 
Signed-off-by: galal-hussein <[email protected]>
@galal-hussein
golintci
0d0b165 
Signed-off-by: galal-hussein <[email protected]>
@galal-hussein galal-hussein merged commit 6739aa0 into rancher:main Dec 10, 2024
2 checks passed
@jp-gouin jp-gouin mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@enrichman enrichman enrichman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galal-hussein @enrichman @briandowns