Fix #169 -- add systemd env options #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falltrades
reviewed
May 31, 2024
|
|
||
| # See https://docs.rke2.io/advanced#configuring-an-http-proxy | ||
| # Add proxy information for the systemd environment | ||
| # systemd-extra-env: |
There was a problem hiding this comment.
Suggested change
| # systemd-extra-env: | |
| # systemd_extra_env: |
Falltrades
reviewed
May 31, 2024
|
|
||
| - name: Add the systemd env file | ||
| ansible.builtin.blockinfile: | ||
| path: /etc/default/rke2-{{ caller_role_name }} |
There was a problem hiding this comment.
Suggested change
| path: /etc/default/rke2-{{ caller_role_name }} | |
| path: /etc/default/rke2-{{ rke2_common_caller_role_name }} |
Falltrades
reviewed
May 31, 2024
|
|
||
| # See https://docs.rke2.io/advanced#configuring-an-http-proxy | ||
| # Add proxy information for the systemd environment | ||
| # systemd-extra-env: |
There was a problem hiding this comment.
Suggested change
| # systemd-extra-env: | |
| # systemd_extra_env: |
Falltrades
reviewed
May 31, 2024
| {% for item in systemd_extra_env %} | ||
| {{ item }} | ||
| {% endfor %} | ||
| - name: Reload the systemd daemon |
There was a problem hiding this comment.
Maybe is it better to use handlers ?
4 tasks
|
address via #242 due to rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It adds the optional ability to add and configure an rke-{server,agent} systemd environment file to /etc/default
Which issue(s) this PR fixes:
Fixes #169
Release Notes