Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated RoPE statement #423

Merged
merged 3 commits into from
Oct 30, 2024
Merged

updated RoPE statement #423

merged 3 commits into from
Oct 30, 2024
+3 −1

Conversation

d-kleine
Copy link
Contributor

  • updated statement about RoPE that it captures both absolute as well as relative positional information
  • added Llama-3.2-3B models to .gitignore

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@d-kleine d-kleine marked this pull request as ready for review October 30, 2024 07:47
rasbt
rasbt approved these changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@rasbt rasbt merged commit 81eed9a into rasbt:main Oct 30, 2024
8 checks passed
@d-kleine d-kleine deleted the llama2_rope branch October 30, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasbt rasbt rasbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-kleine @rasbt