Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor readability improvement in dataloader.ipynb #461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor readability improvement in dataloader.ipynb #461

wants to merge 1 commit into from

Conversation

tao-qian
Copy link

  • The tokenizer and encoded_text variables at the root level are unused.
  • The default params for create_dataloader_v1 are confusing, especially for the default batch_size 4, which happens to be the same as the max_length.

@tao-qian
Minor readability improvement in dataloader.ipynb
4f16cea 
- The tokenizer and encoded_text variables at the root level are unused.
- The default params for create_dataloader_v1 are confusing, especially for the default batch_size 4, which happens to be the same as the max_length.
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@rasbt
Copy link
Owner

rasbt commented Dec 31, 2024

Thanks for the PR! Currently recovering from an injury and will have a closer look in January but at first glance this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tao-qian @rasbt