Skip to content

Commit

Permalink
Address review comments #1
Browse files Browse the repository at this point in the history
- Suggest disabling AOF on gcsfuse, s3
- Update redis version
- Don't provide a default storageClass
  • Loading branch information
spencer-p committed Jan 3, 2025
1 parent c2e0d10 commit 8c18e44
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
8 changes: 4 additions & 4 deletions docs/best-practice/gcs-fault-tolerance-persistent-redis.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ replica) Redis, so clustering is omitted.

## Persistent storage

Specialty storage volumes (like Google Cloud Storage FUSE or S3) are not
recommended because append operations are not supported, which Redis uses to
efficiently write its Append Only File (AOF) log.
Specialty storage volumes (like Google Cloud Storage FUSE or S3) do not support
append operations, which Redis uses to efficiently write its Append Only File
(AOF) log. When using using these options, it is recommended to disable AOF.

With GCP GKE and Azure AKS, the default storage classes are [persistent
disks](https://cloud.google.com/kubernetes-engine/docs/concepts/persistent-volumes)
Expand Down Expand Up @@ -97,7 +97,7 @@ auto-aof-rewrite-min-size 64mb
```

You can view the full reference for 5.0.8
[here](https://raw.githubusercontent.com/redis/redis/refs/tags/5.0.8/redis.conf).
[here](https://raw.githubusercontent.com/redis/redis/refs/tags/7.4.0/redis.conf).


If your job is generally idempotent and can resume from several minutes of state
Expand Down
5 changes: 3 additions & 2 deletions ray-operator/config/samples/ray-cluster.persistent-redis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ spec:
resources:
requests:
storage: 8Gi
storageClassName: standard-rwo
# choose a storageClassName provided by your Kubernetes:
#storageClassName: standard-rwo
---
apiVersion: apps/v1
kind: StatefulSet
Expand All @@ -160,7 +161,7 @@ spec:
spec:
containers:
- name: redis
image: redis:5.0.8
image: redis:7.4.0
command:
- "sh"
- "-c"
Expand Down

0 comments on commit 8c18e44

Please sign in to comment.