Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add sample yaml rayjob test cases #2487

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

fscnick
Copy link
Contributor

@fscnick fscnick commented Nov 1, 2024

Why are these changes needed?

  • add rayjob_test.go to check RayJob can successfully create RayCluster
  • the following yamls are not included:
    • ray-job.batch-inference.yaml
    • ray-job.tpu-v6e-16-multihost.yaml
    • ray-job.tpu-v6e-256-multihost.yaml
    • ray-job.tpu-v6e-singlehost.yaml

Related issue number

Closes #2452

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@fscnick
Copy link
Contributor Author

fscnick commented Nov 1, 2024

@MortalHappiness PTAL

ray-operator/test/sampleyaml/rayjob_test.go Show resolved Hide resolved
ray-operator/controllers/ray/common/association.go Outdated Show resolved Hide resolved
ray-operator/test/sampleyaml/rayjob_test.go Outdated Show resolved Hide resolved
ray-operator/test/support/ray.go Outdated Show resolved Hide resolved
ray-operator/test/support/ray.go Outdated Show resolved Hide resolved
Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 43 to 45
test.T().Logf("Waiting for RayJob %s/%s to be running", namespace.Name, rayJobFromYaml.Name)
g.Eventually(RayJob(test, namespace.Name, rayJobFromYaml.Name), TestTimeoutMedium).
Should(WithTransform(RayJobStatus, Equal(rayv1.JobStatusRunning)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines because Running is a transition state, we don't need to check it here.

@kevin85421 kevin85421 merged commit 1b2764d into ray-project:master Nov 5, 2024
29 checks passed
@fscnick fscnick deleted the test/sampleyaml-rayjob branch November 8, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check RayJob successfully create RayCluster
3 participants