[Feat] Add support user-defined serve service ports #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ren MinMin <[email protected]>
Comment on lines
+129
to
+155
| instanceWithoutSvc = &rayv1.RayCluster{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "raycluster-sample-nosvc", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: rayv1.RayClusterSpec{ | ||
| HeadServiceAnnotations: map[string]string{ | ||
| headServiceAnnotationKey1: headServiceAnnotationValue1, | ||
| headServiceAnnotationKey2: headServiceAnnotationValue2, | ||
| }, | ||
| HeadGroupSpec: rayv1.HeadGroupSpec{ | ||
| ServiceType: corev1.ServiceTypeClusterIP, | ||
| Template: corev1.PodTemplateSpec{ | ||
| Spec: corev1.PodSpec{ | ||
| Containers: []corev1.Container{ | ||
| { | ||
| Name: "ray-head", | ||
| Ports: []corev1.ContainerPort{ | ||
| {ContainerPort: 10001, Name: "client"}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Why not use instanceForSvc directly? They are almost the same.
There was a problem hiding this comment.
They are different, instanceWithoutSvc does not include the "serve" container port for the service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Users may only need to customize the serve service to use the NodePort mode for external access, but currently, the implementation requires setting all ports in the cluster to NodePort mode.
Related issue number
Checks