Refactor UpgradeStrategy to UpgradeSpec.Type #2678
Open
+145
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanaoleary <[email protected]>
andrewsykim
reviewed
Dec 30, 2024
| // UpgradeStrategy represents the strategy used when upgrading the RayService. Currently supports `NewCluster` and `None` | ||
| UpgradeStrategy *RayServiceUpgradeStrategy `json:"upgradeStrategy,omitempty"` | ||
| // UpgradeSpec defines the scaling policy used when upgrading the RayService. | ||
| UpgradeSpec *RayServiceUpgradeSpec `json:"upgradeSpec,omitempty"` |
There was a problem hiding this comment.
spec.upgradeStrategy.type instead of spec.upgradeSpec.type?
There was a problem hiding this comment.
Sure that sounds more clear, RayServiceUpgradeStrategy was already in use to define the string constant, but I went ahead and changed that field to RayServiceUpgradeType instead. 97816e8
Signed-off-by: ryanaoleary <[email protected]>
|
@ryanaoleary can you fix the CI failure? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR changes
UpgradeStrategyto a fieldTypein a newUpgradeSpecfield underRayServiceSpec. This will make it easier to add other upgrade related fields to the RayService CR in the future.Related issue number
Checks