Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zerion extension #15877

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Update zerion extension #15877

merged 10 commits into from
Dec 20, 2024

Conversation

zerts
Copy link
Contributor

@zerts zerts commented Dec 15, 2024

Description

A big update created by the Zerion team.

Improvements:

  • View any Ethereum address profile directly inside Raycast
  • Safe a list of profiles for the quick access
  • Pin any profile to the MenuBar

Screencast

Zerts.Screenshot.Dec.15.2024.mp4

Checklist

- Merge branch \'contributions/merge-1734276660475\'
- Pull contributions
- Merge branch \'contributions/merge-1734274808161\'
- Pull contributions
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 15, 2024

Thank you for your contribution! 🎉

🔔 @qd-qd you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: zerion Issues related to the zerion extension labels Dec 15, 2024
@zerts
Copy link
Contributor Author

zerts commented Dec 15, 2024

All changes are discussed with the creator of the extension and pushed into the original repository: https://github.com/qd-qd/raycast-zerion

Comment on lines 151 to 152
},
"version": "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
"version": "2.0.0"
}

The version field is not needed. Raycast never uses it for any purpose.

@@ -0,0 +1,161 @@
import { groupBy } from "lodash";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { groupBy } from "lodash";
import groupBy from "lodash/groupBy.js";

You can import the groupBy in this way to get a smaller distribution file size.

Comment on lines 3 to 9

## [Zerion Client ] - 2024-12-17 (2.0.0)
- View wallet portfolio
- Search tokens, addresses or domains
- Show Wallet total value in the menu bar
- Safe multiple addresses for quick access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [Initial Version] - 2024-01-18 (1.0.0)
## [Zerion Client ] - 2024-12-17 (2.0.0)
- View wallet portfolio
- Search tokens, addresses or domains
- Show Wallet total value in the menu bar
- Safe multiple addresses for quick access
## [Zerion Client] - {PR_MERGE_DATE}
- View wallet portfolio
- Search tokens, addresses or domains
- Show Wallet total value in the menu bar
- Safe multiple addresses for quick access
## [Initial Version] - 2024-01-18

Incorrect order. The new changelog should be on the top. The version is nonsense and unneeded.

@zerts
Copy link
Contributor Author

zerts commented Dec 15, 2024

@LitoMore, thank you for your comments!
Fixed!

@@ -1,3 +1,9 @@
# Zerion Changelog

## [Zerion Client ] - 2024-12-17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [Zerion Client ] - 2024-12-17
## [Zerion Client] - {PR_MERGE_DATE}

The date can be {PR_MERGE_DATE} here. The Raycast bot will replace the string with merge date for you.

And there is trailing space after the Zerion Client. It can be removed.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer self-assigned this Dec 20, 2024
@raycastbot raycastbot merged commit c5530c5 into raycast:main Dec 20, 2024
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/qdqd/zerion

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: zerion Issues related to the zerion extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants