Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Remove info item from emulators list #15960

Merged
merged 4 commits into from
Dec 20, 2024
Merged

fix(android): Remove info item from emulators list #15960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fb2125
fix(android): list emulators without info debug
gutenye Dec 20, 2024
0c9f6c5
update changelog
gutenye Dec 20, 2024
1a848e6
improve writing
gutenye Dec 20, 2024
2f135ec
Merge branch 'main' into android-info
pernielsentikaer Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Update] - 2024-12-20

- Remove info item from emulators list
- Fix suppress stderr toast messages on emulator launch

## [Feature Update] - 2024-02-23
Expand Down
2 changes: 1 addition & 1 deletion extensions/android/src/util/emulatorUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
const emulators = avdsResponse
.split("\n")
.map((item) => item.trim())
.filter((item) => item.length > 0)
.filter((item) => !item.startsWith("INFO |") && item.length > 0)
.map((item) => {
const runningEmulator = runningEmulators.find(
(runningEmulator) => runningEmulator.name === item
Expand All @@ -80,7 +80,7 @@
};
return emulator;
})
.sort((a, b) => {

Check warning on line 83 in extensions/android/src/util/emulatorUtil.ts

View workflow job for this annotation

GitHub Actions / Check 

'b' is defined but never used
if (a.state === EmulatorState.Running) {
return -1;
}
Expand Down
Loading