Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Suppress stderr toast messages on emulator launch #15961

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

gutenye
Copy link
Contributor

@gutenye gutenye commented Dec 20, 2024

Description

Previously, stderr messages were shown when opening the emulator.

SCR-20241220-kmhw

Now, no stderr messages appear.

Here’s why:
1. The stderr messages don’t impact the emulator’s ability to open; it still functions properly even with the messages.
2. There were numerous stderr messages, but the toast notification could only display one, which didn’t provide much value.

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: android Issues related to the android extension labels Dec 20, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 20, 2024

Thank you for your contribution! 🎉

🔔 @MohamedISoliman @3llomi you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@gutenye gutenye changed the title fix(android): silent stderr toast messages fix(android): Suppress stderr toast messages on emulator launch Dec 20, 2024
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 8867119 into raycast:main Dec 20, 2024
9 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/mibrahimdev/android

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: android Issues related to the android extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants