-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pointDown action #444
Open
enson0131
wants to merge
5
commits into
react-component:master
Choose a base branch
from
enson0131:feature/addAction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1be7cd6
feat: ✨ add pointerDown action
enson0131 526263e
fix: 🐞 add pointerDown
enson0131 b894b0d
Update src/index.tsx
afc163 a3ada2f
fix: 🐞 fix bug
enson0131 11b9074
Merge branch 'feature/addAction' of https://github.com/enson0131/trig…
enson0131 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码更改看起来不错!
新添加的代码正确地实现了处理
onPointDown
事件的功能。该逻辑检查是否启用了在指针按下事件上显示或隐藏组件的操作。如果是,它会为cloneProps.onPointDown
分配一个新的事件处理程序。此处理程序根据当前状态和指定的操作来确定是触发打开还是关闭组件。提醒:为新代码路径添加测试。
静态分析工具指出,添加的第 538 行和第 540 行未被测试覆盖。
您希望我生成测试代码还是开一个 GitHub issue 来跟踪此任务?
Tools
GitHub Check: codecov/patch