docs: update broken react-native-reanimated links #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
requested changes
Nov 5, 2023
|
@satya164 agree, done! |
satya164
requested changes
Nov 6, 2023
| @@ -38,7 +38,7 @@ Then, you need to install and configure the libraries that are required by the d | |||
| npm install react-native-gesture-handler react-native-reanimated | |||
| ``` | |||
|
|
|||
| The Drawer supports both Reanimated 1 and Reanimated 2. If you want to use Reanimated 2, make sure to configure it following the [installation guide](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation). | |||
| The Drawer supports the latest version of Reanimated. Make sure to configure it following the [installation guide](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/getting-started). | |||
There was a problem hiding this comment.
This isn't quite correct. It supports both Reanimated 1 and the latest version. Reanimated 1 has a different API and supported via useLegacyImplementation prop. The latest version of Reanimated needs additional configuration.
Basically what was written before, but Reanimated 2 should be replaced by latest version.
There was a problem hiding this comment.
@satya164 You're right, sorry for the confusion. Sent a fix, let me know if it's good now!
satya164
reviewed
Nov 6, 2023
satya164
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few broken links pointing to react-naitve-reanimated 2 and 3.
In their new docs, v2 installation is now at
/docs/2.x/fundamentals/installation, and v3 atdocs/fundamentals/getting-started