Replace removed labelVisible with displayMode.
#1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Nov 18, 2024
**Motivation** I noticed while migrating from v6 to v7 that `labelVisible` was changed to `displayMode`. The migration guide and the elements documentation pages did not include this information, so I went ahead and [updated them](react-navigation/react-navigation.github.io#1384) (the PR just landed). However, I noticed while hovering in my IDE (VS Code) that the description for `displayMode` was not updated. I went ahead and updated it in the types to match the `headerBackButtonDisplayMode` description (it's the same property). **Test plan** There are no code changes, this is strictly related to TypeScript DX. Before:  After: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was migrating to React Navigation v7 and I noticed that the docs were a bit outdated. I referred to this elements changelog and this Native Stack Navigator docs page when making my changes.
I updated the elements docs page itself, and the migration guide to help others with their migrations. Feel free to move it to a different category, as I created a new one for it
"Changes to elements".Please verify my formatting before accepting. I noticed you usually put the default value after the possible values, but I wasn't able to figure out how to do that within the list.
Thanks for the awesome library, I hope I was able to help fix the issue!