SbeTool.main -> provide additional method SbeTool.mainWithProperties to aid build tools #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add overload for main in SbeTool.main
smandy
changed the title
smandy
changed the title
smandy
force-pushed
the
main_properties_overload
branch
from
07aa26c to
45755a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A static main (named 'mainWithProperties') that takes external properties so that build tools can supply their own properties, rather than injecting config by polluting system properties; This is a disaster in a multi-threaded build where system properties amount to shared global state and so separate invocations of SbeTool.main will end up trashing the properties of other invocations that are running concurrently :-( This new method allows parallel, independent invocations that don't interfere with each other and retains compatibility with existing command line workflows. The existing main now defers to this method passing System.getProperties() as the 'properties' argument.