Skip to content

Commit

Permalink
Upgrade bs-platform to 9.0.2 (#700)
Browse files Browse the repository at this point in the history
  • Loading branch information
davesnx authored Feb 10, 2023
1 parent f585568 commit 44dc69c
Show file tree
Hide file tree
Showing 7 changed files with 1,304 additions and 1,355 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@
},
"homepage": "https://reasonml.github.io/reason-react/",
"devDependencies": {
"bs-platform": "^7.3.1",
"bs-platform": "^9.0.2",
"jest": "^26.0.1",
"react": "^16.8.1",
"react-dom": "^16.8.1",
"reason-test-framework": "^0.3.2"
},
"peerDependencies": {
"bs-platform": "^7.1.1",
"bs-platform": "^9.0.2",
"react": "^16.8.1",
"react-dom": "^16.8.1"
},
Expand Down
7 changes: 4 additions & 3 deletions src/React.re
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ type componentLike('props, 'return) = 'props => 'return;
type component('props) = componentLike('props, element);

/* this function exists to prepare for making `component` abstract */
external component: componentLike('props, element) => component('props) = "%identity";
external component: componentLike('props, element) => component('props) =
"%identity";

[@bs.module "react"]
external createElement: (component('props), 'props) => element =
Expand Down Expand Up @@ -160,8 +161,8 @@ module SuspenseList = {
external makeProps:
(
~children: element=?,
~revealOrder: [@bs.string] [ | `forwards | `backwards | `together]=?,
~tail: [@bs.string] [ | `collapsed | `hidden]=?,
~revealOrder: [ | `forwards | `backwards | `together]=?,
~tail: [ | `collapsed | `hidden]=?,
unit
) =>
{
Expand Down
2 changes: 1 addition & 1 deletion src/ReasonReactErrorBoundary.re
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* Important note on this module:
* As soon as React provides a mechanism for error-catching using functional component,
* this is likely to be deprecated and/or move to user space.
* this is likely to be deprecated and/or move to user space.
*/
type reactComponentClass;

Expand Down
2 changes: 1 addition & 1 deletion src/ReasonReactErrorBoundary.rei
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* Important note on this module:
* As soon as React provides a mechanism for error-catching using functional component,
* this is likely to be deprecated and/or move to user space.
* this is likely to be deprecated and/or move to user space.
*/
type info = {componentStack: string};

Expand Down
2 changes: 1 addition & 1 deletion src/ReasonReactRouter.re
Original file line number Diff line number Diff line change
Expand Up @@ -212,4 +212,4 @@ let useUrl = (~serverUrl=?, ()) => {
});

url;
};
};
3 changes: 1 addition & 2 deletions test/React__test.re
Original file line number Diff line number Diff line change
Expand Up @@ -620,8 +620,7 @@ describe("React", ({test, beforeEach, afterEach}) => {
act(() => {
ReactDOM.render(
<ReasonReactErrorBoundary
fallback={({error, info}) => {
expect.value(error).toEqual(ComponentThatThrows.TestError);
fallback={({error: _, info}) => {
expect.bool(
info.componentStack->Js.String2.includes("ComponentThatThrows"),
).
Expand Down
Loading

0 comments on commit 44dc69c

Please sign in to comment.