-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-dom): add experimental module #849
Open
r17x
wants to merge
5
commits into
reasonml:main
Choose a base branch
from
r17x:feat/experimental/react-dom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r17x
commented
Jul 19, 2024
davesnx
reviewed
Jul 21, 2024
davesnx
reviewed
Jul 21, 2024
davesnx
approved these changes
Jul 21, 2024
r17x
force-pushed
the
feat/experimental/react-dom
branch
from
July 21, 2024 06:50
8f6f928
to
bb2fafe
Compare
davesnx
reviewed
Jul 21, 2024
davesnx
reviewed
Jul 21, 2024
list of experimental bind: * preconnect * prefetchDNS * preinit * preinitModule * preload * preloadModule
r17x
force-pushed
the
feat/experimental/react-dom
branch
from
July 21, 2024 07:46
bb2fafe
to
57d426b
Compare
davesnx
reviewed
Jul 21, 2024
r17x
force-pushed
the
feat/experimental/react-dom
branch
from
July 21, 2024 19:53
24f04c7
to
26e7c3c
Compare
r17x
commented
Jul 21, 2024
module Experimental = { | ||
type preloadOptions; | ||
|
||
[@mel.obj] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using [@mel.obj]
in preloadOptions because wants to use [@mel.as]
when polyvar contains preserved keyword and included -
.
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's
Binding experimental features module for
react-dom
.list of experimental bind:
Usages