Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to define Cartoon as episode based #1441

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Dec 29, 2024

Supposed to be based on

TvType.Cartoon -> "Cartoons/$sanitizedFileName"

Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please at least think of some optimizations, you just alloc for a simple if statement. source

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 29, 2024

Please at least think of some optimizations, you just alloc for a simple if statement. source

So sorry but I have no idea what you mean?

@fire-light42
Copy link
Collaborator

Please at least think of some optimizations, you just alloc for a simple if statement. source

So sorry but I have no idea what you mean?

You are currently allocating memory taking extra cpu time, instead of using super fast tableswitch operation (aka when). Even if cs3 does not really optimize our code, refactoring fast code to be slower is a bit of a gut punch.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 29, 2024

Please at least think of some optimizations, you just alloc for a simple if statement. source

So sorry but I have no idea what you mean?

You are currently allocating memory taking extra cpu time, instead of using super fast tableswitch operation (aka when). Even if cs3 does not really optimize our code, refactoring fast code to be slower is a bit of a gut punch.

Oh that makes sense I didn't even think of that my intent for the change was readability I didn't even consider the performance aspect. My bad.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 29, 2024

Please at least think of some optimizations, you just alloc for a simple if statement. source

If I understood correctly I think I did what you were asking...

@Luna712 Luna712 requested a review from fire-light42 December 31, 2024 02:05
@Luna712 Luna712 mentioned this pull request Dec 31, 2024
@fire-light42 fire-light42 merged commit ed6b848 into recloudstream:master Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants