Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159 Removed annotation selection dismissal filtering by a reason #160

Conversation

oleksandr-danylchenko
Copy link
Contributor

Issue - #159

@oleksandr-danylchenko
Copy link
Contributor Author

We still need the reason filtering, because the popup shouldn't be dismissed, or, even worse, annotation selection shouldn't get cleared on outside-click. That will lead to the race condition between the SelectionHander and FloatingUI who will cancel the selection first.

@oleksandr-danylchenko oleksandr-danylchenko deleted the #159-simplify-popup-dismissal branch October 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant