Enable pipeline SA to read and list plrs #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR enables the appstudio-pipeline service account to get and list PipelineRuns - The motivation for this is to allow Integration Test Scenarios PipelineRuns to query itself to inspect label and annotations added by the Integration Service such as: ``` appstudio.openshift.io/component: acb-service test.appstudio.openshift.io/type: component ``` which tells you that the underlying Snapshot for this Test was created by a component that was recently built called `abc-service` Signed-off-by: Scott Hebert <[email protected]>
scoheb
requested review from
ralphbean,
hugares and
gabemontero
and removed request for
MatousJobanek and
mfrancisc
scoheb
added a commit
to scoheb/ec-cli
that referenced
this pull request
Aug 28, 2024
- Introducing Single Component Mode - See KONFLUX-4059 - This step, if activated by the SINGLE_COMPONENT parameter and a valid pipelinerun name, will attempt to reduce the incoming snapshot to contain a single component. That component being the one that caused the snapshot to create for. - This is determined by examining the labels of the currently running pipelinerun: ``` appstudio.openshift.io/component: acb-service test.appstudio.openshift.io/type: component ``` - This tells you that the underlying snapshot for this Test was created by a `component` that was recently built called `abc-service` NOTE: This requires redhat-appstudio/infra-deployments#4413 Signed-off-by: Scott Hebert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, ralphbean, scoheb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a454002
into
redhat-appstudio:main
4 checks passed
scoheb
added a commit
to scoheb/ec-cli
that referenced
this pull request
Aug 29, 2024
- Introducing Single Component Mode - See KONFLUX-4059 - This step, if activated by the SINGLE_COMPONENT parameter and a valid pipelinerun name, will attempt to reduce the incoming snapshot to contain a single component. That component being the one that caused the snapshot to create for. - This is determined by examining the labels of the currently running pipelinerun: ``` appstudio.openshift.io/component: acb-service test.appstudio.openshift.io/type: component ``` - This tells you that the underlying snapshot for this Test was created by a `component` that was recently built called `abc-service` NOTE: This requires redhat-appstudio/infra-deployments#4413 Signed-off-by: Scott Hebert <[email protected]>
scoheb
added a commit
to scoheb/ec-cli
that referenced
this pull request
Sep 4, 2024
- Introducing Single Component Mode - See KONFLUX-4059 - This step, if activated by the SINGLE_COMPONENT parameter and a valid pipelinerun name, will attempt to reduce the incoming snapshot to contain a single component. That component being the one that caused the snapshot to create for. - This is determined by examining the labels of the currently running pipelinerun: ``` appstudio.openshift.io/component: acb-service test.appstudio.openshift.io/type: component ``` - This tells you that the underlying snapshot for this Test was created by a `component` that was recently built called `abc-service` NOTE: This requires redhat-appstudio/infra-deployments#4413 Signed-off-by: Scott Hebert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which tells you that the underlying Snapshot for this Test was created by a component that was recently built called
abc-serviceAddresses KONFLUX-4171