KFLUXINFRA-802: Adding Node Selector and Tolerations in TektonConfig

[manish-jangra]

Adding Node Selector and Tolerations in TektonConfig to make use of the default pod template for the PipelineRuns and TaskRuns.

Related Pull Request for Stage Member Cluster (m01) -

• KFLUXINFRA-802: Segregate Konflux and Tenants Workload using TektonConfig #4397

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[manish-jangra]

/test all

[openshift-ci]

@manish-jangra: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

• /test appstudio-e2e-tests
• /test appstudio-load-test

The following commands are available to trigger optional jobs:

• /test appstudio-hac-e2e-tests
• /test appstudio-upgrade-tests

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[enarha]

@manish-jangra Adding kustomization patches in the per cluster resources directory is good if you want to test on a single cluster or if you want to have different values on each cluster. If you have the same values per cluster type (stage/prod) or for all clusters, the way to do it if add it just once per environment, development (used by the CI and developer) https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/development/main-pipeline-service-configuration.yaml#L1478 , staging https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/staging/base/main-pipeline-service-configuration.yaml#L1294 and production https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/production/base/main-pipeline-service-configuration.yaml#L1445. Once you add your changes, you use the generate script to update the deploy.yaml files for all staging and production clusters.

[bamachrn]

I agree with @enarha lets right the nodeselector in one place and patch it the deployconfigs for other clusters. so that we dont repeat the same codes.

[manish-jangra]

@manish-jangra Adding kustomization patches in the per cluster resources directory is good if you want to test on a single cluster or if you want to have different values on each cluster. If you have the same values per cluster type (stage/prod) or for all clusters, the way to do it if add it just once per environment, development (used by the CI and developer) https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/development/main-pipeline-service-configuration.yaml#L1478 , staging https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/staging/base/main-pipeline-service-configuration.yaml#L1294 and production https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/production/base/main-pipeline-service-configuration.yaml#L1445. Once you add your changes, you use the generate script to update the deploy.yaml files for all staging and production clusters.

@enarha I have made the changes as suggested. Please review, It should be good now.

[hugares]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, manish-jangra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/pipeline-service/OWNERS [hugares,manish-jangra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[enarha]

@manish-jangra The changes to staging and production are good. Please add the change to the development environment as well (https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/development/main-pipeline-service-configuration.yaml#L1478). This is what the Konflux CI and manual deployments use and we want to keep it as close as possible to prod/stage, even if the change does not have real impact. There is no need to run the generate script on development change. Once done, the change is good to be merged IMO.

[enarha]

/lgtm