Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-4180): Dashboard with workers performance #4418

Conversation

jhutar
Copy link
Member

@jhutar jhutar commented Aug 29, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from avi-biton and eisraeli August 29, 2024 13:07
@jhutar jhutar changed the title WIP: feat(KONFLUX-4180): Dashboard with workers performance feat(KONFLUX-4180): Dashboard with workers performance Aug 29, 2024
@jhutar
Copy link
Member Author

jhutar commented Aug 29, 2024

Installed development cluster to Hive OpenShift and new dashboard was there, so removing "WIP" status and IMHO this is ready.

@jhutar
Copy link
Member Author

jhutar commented Aug 29, 2024

/retest

@jhutar jhutar force-pushed the fix36-workers-perf-dashboard branch from c0822ce to e9f000d Compare August 30, 2024 10:06
Copy link

openshift-ci bot commented Aug 30, 2024

@jhutar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests e9f000d link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhutar
Copy link
Member Author

jhutar commented Aug 30, 2024

As per info from https://redhat-internal.slack.com/archives/C02FANRBZQD/p1724996415221919 this error in ci/prow/appstudio-hac-e2e-tests is ongoing auth issue and the test itself is not mandatory, so it should not block merging this.

Copy link
Contributor

@avi-biton avi-biton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avi-biton, jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 10c0019 into redhat-appstudio:main Sep 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants