Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: pass relevant requests to workspaces #4427

Merged

Conversation

sadlerap
Copy link
Contributor

Workspaces is now live in production environments, but is currently inaccessible as it's not exposed. In external environments, workspaces is configured to use a route, but on internal environments, it can piggy-back off of the nginx configuration already in place for UI components.

Workspaces is now live in production environments, but is currently
inaccessible as it's not exposed.  In external environments, workspaces
is configured to use a route, but on internal environments, it can
piggy-back off of the nginx configuration already in place for UI
components.

Signed-off-by: Andy Sadler <[email protected]>
@openshift-ci openshift-ci bot requested review from arewm and zregvart August 29, 2024 20:01
Copy link

openshift-ci bot commented Aug 29, 2024

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests ddccbda link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arewm arewm requested review from dperaza4dustbit and removed request for zregvart and arewm August 29, 2024 22:54
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 77f99a3 into redhat-appstudio:main Aug 30, 2024
6 of 7 checks passed
@sadlerap sadlerap deleted the workspaces-proxy branch August 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants