-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Qute fragments doesn't work with non inner Templates Java file #1170
Conversation
I need to write test. |
77dbb50
to
5b7e0c0
Compare
I have written tests, let's see if CI build is working. |
looks like the open fragment codelens only open the file at Line 1, regardless of the fragment's offset. I don't know how the links work, but maybe something like |
Indeed it is because it is not implemented, see #1169 (comment)
Perhaps but it requires that Qute Language server provides a command which returns the offset of a given fragment for a given template |
0192271
to
7de6786
Compare
Fixes redhat-developer#1169 Signed-off-by: azerr <[email protected]>
7de6786
to
5e454be
Compare
Kudos, SonarCloud Quality Gate passed! |
Tests are woking now. |
Thanks @angelozerr! |
fix: Qute fragments doesn't work with non inner Templates Java file
Fixes #1169
Given this non inner class:
With this PR Fragment should be recognized