Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect basePath in @CheckedTemplate to find templates #1173

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: respect basePath in @CheckedTemplate to find templates #1173

merged 1 commit into from
Sep 21, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Sep 18, 2023 •
edited
Loading

Still need to :

  • handle corner cases, i.e empty paths, several "/"s
  • write tests

@fbricon fbricon added this to the 1.29.0 milestone Sep 18, 2023
@fbricon fbricon self-assigned this Sep 18, 2023
@angelozerr
Copy link
Contributor

@fbricon I suppose we have the same issue in JDT, right?

@fbricon
Copy link
Contributor Author

fbricon commented Sep 18, 2023

see redhat-developer/quarkus-ls#893

@angelozerr angelozerr mentioned this pull request Sep 18, 2023
Closed
@fbricon fbricon force-pushed the checkedtemplates-basepath branch from 735f26d to 92ee81c Compare September 19, 2023 09:00
@fbricon fbricon marked this pull request as ready for review September 19, 2023 09:01
@fbricon fbricon force-pushed the checkedtemplates-basepath branch 2 times, most recently from fbd7452 to 196f267 Compare September 19, 2023 09:17
@angelozerr
Copy link
Contributor

After adding Javadoc, I think we can merge this nice PR.

@fbricon fbricon force-pushed the checkedtemplates-basepath branch from 196f267 to 6bf17d8 Compare September 21, 2023 15:01
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.6% 15.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@angelozerr angelozerr merged commit d817830 into redhat-developer:main Sep 21, 2023
8 of 12 checks passed
@angelozerr
Copy link
Contributor

Thanks @fbricon !

@fbricon
Copy link
Contributor Author

fbricon commented Sep 21, 2023

@ia3andy you can check https://github.com/redhat-developer/intellij-quarkus/actions/runs/6263683196

@fbricon fbricon mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

Assignees

@fbricon fbricon

Labels
None yet
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fbricon @angelozerr