Update to LSP4MP 0.13.3

[rgrunber]

• ProjectLabelTest, and PropertiesManagerLocationTest should import all test projects initially (@BeforeClass) as now, load{Maven,Gradle}Project will clear any previously imported test projects
• quarkus-renarde-todo, microprofile-applicationpath test projects do not need .project/.classpath files
• artifactID should match project folder for quarkus-renarde-todo

[datho7561]

There's a test that failing consistently: PropertiesManagerLocationTest.usingVertxTest

[datho7561]

This fixed the vertx test for me:

diff --git a/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/PropertiesManagerLocationTest.java b/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/PropertiesManagerLocationTest.java
index fb33f04e..47acc2a0 100644
--- a/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/PropertiesManagerLocationTest.java
+++ b/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/PropertiesManagerLocationTest.java
@@ -19,12 +19,14 @@ import org.eclipse.jdt.core.IJavaProject;
 import org.eclipse.jdt.core.IMember;
 import org.eclipse.jdt.core.JavaModelException;
 import org.eclipse.jdt.ls.core.internal.JavaLanguageServerPlugin;
+import org.eclipse.jdt.ls.core.internal.ProjectUtils;
 import org.eclipse.lsp4j.ClientCapabilities;
 import org.eclipse.lsp4j.Location;
 import org.eclipse.lsp4mp.jdt.core.BasePropertiesManagerTest;
 import org.eclipse.lsp4mp.jdt.core.PropertiesManager;
 import org.eclipse.lsp4mp.jdt.core.utils.IJDTUtils;
 import org.junit.Assert;
+import org.junit.BeforeClass;
 import org.junit.Test;
 
 
@@ -36,12 +38,17 @@ import org.junit.Test;
  */
 public class PropertiesManagerLocationTest extends BasePropertiesManagerTest {
 	
+	@BeforeClass
+	public static void setupTetststs() throws CoreException, Exception {
+		loadMavenProject(MicroProfileMavenProjectName.using_vertx);
+	}
+
 	@Test
 	public void usingVertxTest() throws Exception {
 		// Enable classFileContentsSupport to generate jdt Location
 		enableClassFileContentsSupport();
 
-		IJavaProject javaProject = loadMavenProject(MicroProfileMavenProjectName.using_vertx);
+		IJavaProject javaProject = ProjectUtils.getJavaProject(MicroProfileMavenProjectName.using_vertx);
 
 		// Test with JAR
 		// quarkus.datasource.url

[rgrunber]

I think it's worth investigating

ConfigItemIntBoolDefaultValueTest.configItemIntBoolDefaultValueTest:42 expected:<276> but was:<273>
MicroProfileConfigPropertyTest.configQuickstartFromClasspath:37 expected:<276> but was:<273>

before merging. They only fail in the GHA job, and never locally so I suspect something about the GHA configuration.

[rgrunber]

ConfigItemIntBoolDefaultValueTest.configItemIntBoolDefaultValueTest:42 expected:<276> but was:<273>
MicroProfileConfigPropertyTest.configQuickstartFromClasspath:37 expected:<276> but was:<273>

Thanks to @datho7561 for helping me narrow down the issue. Specifically,

https://github.com/eclipse-jdt/eclipse.jdt.core/blob/452a5de1ca83d1641d9a537417c71a531c36f831/org.eclipse.jdt.core/model/org/eclipse/jdt/core/IJavaProject.java#L281-L295

https://github.com/eclipse/lsp4mp/blob/1ba1bcc32da25562b6ee7b42770d5c1539abf85a/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/utils/JDTTypeUtils.java#L45-L51

A progress monitor needs to be passed in to correctly resolve secondary types.

[datho7561]

It might be a good idea to fix this name (this was my fault, sorry)

[datho7561]

Looks good. Thanks, Roland!