Added refactoring for changing with section to let

[AlexXuChen]

Added diagnostic for deprecated #with section and CodeAction to use #let.

Fixes #489

Signed-off-by: Alexander Chen [email protected]

[rgrunber]

As discussed, I think a good starting point would be to highlight the entire range as opposed to just the start element. It's likely that we won't need to set the deprecated tag.

[rgrunber]

Overall, works well. Just a few minor fixes and one special case.

[angelozerr]

In the demo, the code action doesn't generate properly the #let fix (yo can see warning on name and price.

The code action should generate:

{#let name=item.name price=item.price }
  ...
{\let}

After that, please write tests with diagnostic and code action.

[AlexXuChen]

If we use deprecated tags in the future, create

public static Diagnostic createDiagnosticWithTags(Range range, DiagnosticSeverity severity,
	IQuteErrorCode errorCode, List<DiagnosticTag> tags, Object... arguments) {
String message = errorCode.getMessage(arguments);
Diagnostic diagnostic = new Diagnostic(range, message, severity, QUTE_SOURCE,
		errorCode != null ? errorCode.getCode() : null);
diagnostic.setTags(tags);
return diagnostic;
}

in DiagnosticDataFactory.java

[angelozerr]

Add a javadoc

[fbricon]

• as per CodeAction to replace deprecated #with into #let section #489 (comment), #with is not deprecated, so let's avoid that vocabulary in the code.
• The warning should only appear when used in a type safe context.
• There should be a preference to disable the warning.

[fbricon]

the code action should appear as a refactoring item