Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISV-3828] As a developer, I have a template for opening code reviews with a checklist. #761

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[ISV-3828] As a developer, I have a template for opening code reviews with a checklist. #761

merged 2 commits into from
Dec 20, 2024

Conversation

haripate
Copy link
Contributor

No description provided.

@haripate haripate requested review from johnbe11 and mavaras December 20, 2024 01:21
mavaras
mavaras approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@mavaras mavaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simple template. We can work on top of this in the future as needed.

johnbe11
johnbe11 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@johnbe11 johnbe11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

.github/pull_request_template.md Outdated Show resolved Hide resolved
@haripate haripate merged commit 50e7c36 into main Dec 20, 2024
4 checks passed
@haripate haripate deleted the ISV-3828 branch December 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbe11 johnbe11 johnbe11 approved these changes

@mavaras mavaras mavaras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haripate @johnbe11 @mavaras