Update idrac_interfaces.yml #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in for issue redhat-performance#404
sadsfae
requested changes
Jul 30, 2024
config/idrac_interfaces.yml
Outdated
| @@ -59,7 +59,9 @@ uefi_7525_interfaces: NIC.Integrated.1-1-1,NIC.Integrated.1-2-1,NIC.Slot.6-1-1,N | |||
| uefi_r930_interfaces: NIC.Integrated.1-2-1,HardDisk.List.1-1,NIC.Integrated.1-3-1 | |||
|
|
|||
| # To understand how custom overrides and hierarchy work please see https://github.com/redhat-performance/badfish#host-type-overrides | |||
|
|
|||
| #PerfLab | |||
| perflab_foreman_r750_interfaces: NIC.Embedded.1-1-1,HardDisk.List.1-1,NIC.Slot.3-1-1 | |||
There was a problem hiding this comment.
This is not a supported key, you need director_ and foreman_ as the prefix here. Please copy the other entry examples. Since we already have R750 examples you'll need some rack-level overrides here:
e.g.
foreman_cc37_r750_interfaces: NIC.Embedded.1-1-1,HardDisk.List.1-1,NIC.Slot.3-1-1
director_cc37_r750_interfaces: NIC.Slot.3-1-1,HardDisk.List.1-1,NIC.Embedded.1-1-1
- Repeat for each rack that contains your R750 in Performance lab.
https://github.com/redhat-performance/badfish?tab=readme-ov-file#host-type-overrides
updated overrides for cc37 and bb37
sadsfae
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added in for issue #404