Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ubuntu docker tag to v24 #147

Merged
merged 1 commit into from
Nov 21, 2024
Merged

chore(deps): update ubuntu docker tag to v24 #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion itest/container/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:22.04
FROM ubuntu:24.04

RUN \
apt-get update
Expand Down Expand Up @@ -72,7 +72,7 @@
rm source.patch

ENV ADMIN_EMAIL="[email protected]"
ENV ADMIN_PASSWORD="adminpass"

Check warning on line 75 in itest/container/Dockerfile

View workflow job for this annotation

GitHub Actions / Deploy Docker Image - Test (itest/container/Dockerfile, itest/container, integration, Integration...

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "ADMIN_PASSWORD")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ENV ADMIN_REALNAME="Insecure User"

EXPOSE 80
Expand Down