Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #886 #2630

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixed #886 #2630

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d820d0
Update _index.md to fix #885
mich-elle-luna Dec 22, 2023
df2d298
Update _index.md
mich-elle-luna Dec 22, 2023
9487e6a
Update eval.md to fix #886
mich-elle-luna Dec 22, 2023
9a7f9a4
Merge branch 'redis:master' into master
mich-elle-luna Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion commands/eval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ These names of input keys are available to the script as the [_KEYS_ global runt
Any additional input arguments **should not** represent names of keys.

**Important:**
to ensure the correct execution of scripts, both in standalone and clustered deployments, all names of keys that a script accesses must be explicitly provided as input key arguments.
To ensure the correct execution of scripts, both in standalone and clustered deployments, all names of keys that a script accesses must be explicitly provided as input key arguments.
The script **should only** access keys whose names are given as input arguments.
Scripts **should never** access keys with programmatically-generated names or based on the contents of data structures stored in the database.
If a key with expiry (TTL) exists at the start of eval, it will not get expired during the evaluation of a script.
During the evaluation of a Lua script, TTL of a key can go down to zero. After that, it remains zero until the script terminates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Can you give an example?

I thought that we freeze time during evaluation, so TTL will return the same value every time throughout the evaluation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See redis/redis#10300

CC @enjoy-binbin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yean, we will freeze the time during the evaluation, the [P]TTL should return the same value in this case in Redis 7.2


Please refer to the [Redis Programmability](/topics/programmability) and [Introduction to Eval Scripts](/topics/eval-intro) for more information about Lua scripts.

Expand Down
Loading