GCP Module Inclusion and GCP CI #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
added
ci-ready
Includes the GCP module and the first pass at testing around it -- still need to actually complete the buildkite bit and make sure that the GCP_CREDS passthru is legit in buildkite. Currently the standard tiered storage testing works with ubuntu, haven't gotten a clean run with the private proxy in this format -- got an error about focal that is probably related to the ancient image we're using by default in the GCP module since I just copied that bit over from the OG stuff.
CI now works when run locally, still need to validate that it runs on buildkite. Chief issue is the passing in of GCP creds -- not sure what I have will pass muster tbh. Most likely will need to rebuild client image to accept GCP_CREDS as an env var and then use that directly as an ENV var in the script. But want to validate this first 😅 Also did some code stuff * Loosened some firewall rules * bumped the basic ubuntu version to be less ancient * fixed the build script and passed it correctly in buildkite * allowed passing in the squid_acl so that the proxy correctly handles passthru. This need is created by the difference in subnetting techniques between GCP and AWS
gene-redpanda
force-pushed
the
gcp-module-work
branch
from
06074b7 to
96bda37
Compare
gene-redpanda
force-pushed
the
gcp-module-work
branch
from
3d8388e to
afc6227
Compare
gene-redpanda
changed the title
gene-redpanda
requested review from
hcoyote,
r-vasquez and
twmb
and removed request for
hcoyote
r-vasquez
reviewed
Sep 26, 2023
gene-redpanda
force-pushed
the
gcp-module-work
branch
from
c9ebd23 to
b4a52bd
Compare
gene-redpanda
requested review from
vuldin,
pfcurtis and
r-vasquez
and removed request for
hcoyote and
pfcurtis
r-vasquez
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the GCP module and testing around it.
Currently the standard tiered storage testing works with ubuntu -- haven't gotten a clean run with the private proxy in this format -- got an error about focal that is probably related to the ancient image we're using by default in the GCP module since I just copied that bit over from the OG stuff.
A related piece of work that still needs to be done is fixing the buildkite + proxy = error issue.