Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rolling restart #231

Merged
merged 6 commits into from
Oct 16, 2024
Merged

feat: add rolling restart #231

merged 6 commits into from
Oct 16, 2024

Conversation

gene-redpanda
Copy link
Contributor

Adds rolling restart functionality. Can be run against a cluster to restart all nodes in sequence without other changes.

@gene-redpanda
Copy link
Contributor Author

Test result

gene@gene-MacBook-Pro deployment-automation % ansible-playbook ansible/operation-rolling-restart.yml --private-key artifacts/testkey --inventory artifacts/hosts_devex-cicd.ini

PLAY [Redpanda Rolling Restart] **************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [35.86.118.80]

TASK [Check cluster health] ******************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Get node ID] ***************************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Enable maintenance mode] ***************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Verify maintenance mode status] ********************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Check cluster health after enabling maintenance mode] **********************************************************************************************************************
changed: [35.86.118.80]

TASK [Stop Redpanda service] *****************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Start Redpanda service] ****************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Disable maintenance mode] **************************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Verify maintenance mode is disabled] ***************************************************************************************************************************************
changed: [35.86.118.80]

TASK [Check cluster health after disabling maintenance mode] *********************************************************************************************************************
changed: [35.86.118.80]

TASK [Check broker status] *******************************************************************************************************************************************************
changed: [35.86.118.80]

PLAY [Redpanda Rolling Restart] **************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [34.217.38.164]

TASK [Check cluster health] ******************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Get node ID] ***************************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Enable maintenance mode] ***************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Verify maintenance mode status] ********************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Check cluster health after enabling maintenance mode] **********************************************************************************************************************
changed: [34.217.38.164]

TASK [Stop Redpanda service] *****************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Start Redpanda service] ****************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Disable maintenance mode] **************************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Verify maintenance mode is disabled] ***************************************************************************************************************************************
changed: [34.217.38.164]

TASK [Check cluster health after disabling maintenance mode] *********************************************************************************************************************
changed: [34.217.38.164]

TASK [Check broker status] *******************************************************************************************************************************************************
changed: [34.217.38.164]

PLAY [Redpanda Rolling Restart] **************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [54.202.247.58]

TASK [Check cluster health] ******************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Get node ID] ***************************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Enable maintenance mode] ***************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Verify maintenance mode status] ********************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Check cluster health after enabling maintenance mode] **********************************************************************************************************************
changed: [54.202.247.58]

TASK [Stop Redpanda service] *****************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Start Redpanda service] ****************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Disable maintenance mode] **************************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Verify maintenance mode is disabled] ***************************************************************************************************************************************
changed: [54.202.247.58]

TASK [Check cluster health after disabling maintenance mode] *********************************************************************************************************************
changed: [54.202.247.58]

TASK [Check broker status] *******************************************************************************************************************************************************
changed: [54.202.247.58]

PLAY RECAP ***********************************************************************************************************************************************************************
34.217.38.164 : ok=12 changed=11 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
35.86.118.80 : ok=12 changed=11 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
54.202.247.58 : ok=12 changed=11 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0

@gene-redpanda gene-redpanda force-pushed the add-rolling-restart branch 2 times, most recently from 43e5b6d to 38ce182 Compare October 4, 2024 19:29
TLS variable has no impact on prometheus role.

provision_cluster_tls had a duplicate role inclusion.

I also did a doc pass to add references to some important variables.
Includes support for the nightly build + makes some usability improvements to the makefile for topic name and partition count setting.
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gene-redpanda gene-redpanda merged commit 4e055bb into main Oct 16, 2024
3 checks passed
@gene-redpanda gene-redpanda deleted the add-rolling-restart branch November 25, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants