verifier: fix lastConsumableOffsets
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Green CI here: redpanda-data/redpanda#24187 |
bashtanov
reviewed
Dec 5, 2024
This didn't account for tombstones being produced for the same key later in the log. Fix the logic by adding a new `latestKoByPartition` map which tracks the last offset for a given key. By using it in combination with `latestKvByPartition`, we can conclude which non-tombstone record/key has the highest offset for a given partition.
WillemKauf
force-pushed
the
tombstones
branch
from
01dcf48 to
bffac1f
Compare
bashtanov
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't account for tombstones being produced for the same key later in the log.
Fix the logic by adding a new
latestKoByPartitionmap which tracks the last offset for a given key. By using it in combination withlatestKvByPartition, we can conclude which non-tombstone record/key has the highest offset for a given partition.