tls/ossl: Adjusted value of ERROR_UNEXPECTED_PACKET #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using SSL_R_WRONG_VERSION_NUMBER, which is the error OpenSSL returns when it receives a non-TLS packet when expecting a TLS handshake packet. This helps Redpanda because it treats ERROR_UNEXPECTED_PACKET as a benign disconnect error. Added method that can be used to override the OpenSSL message with one that may be more helpful to users. Signed-off-by: Michael Boquard <[email protected]> (cherry picked from commit f12b65f)
michael-redpanda
requested review from
pgellert and
BenPope
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: CORE-8646
Now using SSL_R_WRONG_VERSION_NUMBER, which is the error OpenSSL returns when it receives a non-TLS packet when expecting a TLS handshake packet. This helps Redpanda because it treats ERROR_UNEXPECTED_PACKET as a benign disconnect error.
Added method that can be used to override the OpenSSL message with one that may be more helpful to users.
Signed-off-by: Michael Boquard [email protected]
(cherry picked from commit f12b65f)