Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Router] Fix TS error when passing WrapperProps to <PrivateSet>s #11739

Merged
merged 3 commits into from
Dec 4, 2024
+5 −8
Merged

[Router] Fix TS error when passing WrapperProps to <PrivateSet>s #11739

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e738350
[TS] Fix TS error when passing WrapperProps
Philzen Dec 2, 2024
70f4450
Enable code hinting on `PrivateSet` wrap prop
Philzen Dec 2, 2024
77ed321
fix formatting
Tobbe Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/router/src/Set.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,11 @@ export function Set<WrapperProps>(props: SetProps<WrapperProps>) {
return <>{props.children}</>
}

type PrivateSetProps<P> = Omit<
SetProps<P>,
'private' | 'unauthenticated' | 'wrap'
> & {
/** The page name where a user will be redirected when not authenticated */
unauthenticated: string
wrap?: WrapperType<P> | WrapperType<P>[]
}
type PrivateSetProps<P> = P &
Omit<SetProps<P>, 'private' | 'unauthenticated'> & {
/** The page name where a user will be redirected when not authenticated */
unauthenticated: string
}

/** @deprecated Please use `<PrivateSet>` instead */
export function Private<WrapperProps>(props: PrivateSetProps<WrapperProps>) {
Expand Down
Loading