Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prettier): Ignore a few docs pages because of prettier issue #11791

Merged
merged 2 commits into from
Dec 22, 2024
Merged

chore(prettier): Ignore a few docs pages because of prettier issue #11791

merged 2 commits into from
Dec 22, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 22, 2024 •
edited
Loading

Prettier would mess these files up when applying its formatting, leading to broken code samples in our documentation.

I think this might be a prettier issue, so I filed a report: prettier/prettier#16952

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Dec 22, 2024
@Tobbe Tobbe added this to the chore milestone Dec 22, 2024
@Tobbe Tobbe mentioned this pull request Dec 22, 2024
Merged
Tobbe added a commit that referenced this pull request Dec 22, 2024
@Tobbe
chore(formatting): Fix formatting in auth/src/index.ts (#11792)
77c124b 
Very minor issue introduced by
#11766

The reason it went unnoticed is code formatting with prettier was
broken, so I had gotten used to just ignoring the format check failures.
This is being worked around by
#11791
@Tobbe Tobbe merged commit 58b78d4 into redwoodjs:main Dec 22, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-prettierignore-docs branch December 22, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
chore
Development

Successfully merging this pull request may close these issues.
1 participant
@Tobbe