This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
test: add Mongo Asset's unit testing #141
Draft
KeisukeYamashita
wants to merge
9
commits into
main
Choose a base branch
from
test-mongo-asset-remove
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 36.68% 34.64% -2.04%
==========================================
Files 331 349 +18
Lines 29890 31755 +1865
==========================================
+ Hits 10964 11001 +37
- Misses 17925 19752 +1827
- Partials 1001 1002 +1
|
Signed-off-by: KeisukeYamashita <[email protected]>
KeisukeYamashita
force-pushed
the
test-mongo-asset-remove
branch
from
May 10, 2022 14:21
4e9996e
to
1906509
Compare
KeisukeYamashita
changed the title
test: add Mongo Asset's Remove unit testing
test: add Mongo Asset's May 10, 2022
Remove
unit testing
KeisukeYamashita
changed the title
test: add Mongo Asset's
test: add Mongo Asset's unit testing
May 13, 2022
Remove
unit testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I have added initial unit testing for MongoDB based on this issue 👉 reearth/reearth-visualizer#273.
See details (requirements) in that issue.
I implemented one for a trial to avoid conflicts and decide how we are going to test this method.
What I've done
I have added a unit test for the Asset repository's
Remove
method.What I haven't done
Add unit tests for other methods.
How I tested
The testings are done by the CI GitHub Actions workflow.
This can be also tested locally.
Which point I want you to review particularly
Memo
FYI: This PR is on top of this PR #139