Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: extend plugin to get current location #371

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Dec 9, 2022

Overview

we need to extend the plugin Api to get the current location for the user.

What I've done

use the geolocation api to get (latitude- longitude- altitude)

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit a87b887
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/639657a0b2d0d100096142cf
😎 Deploy Preview https://deploy-preview-371--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #371 (a87b887) into main (2871edd) will increase coverage by 0.01%.
The diff coverage is 32.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   18.42%   18.44%   +0.01%     
==========================================
  Files         524      525       +1     
  Lines       53466    53539      +73     
  Branches      643      644       +1     
==========================================
+ Hits         9849     9873      +24     
- Misses      43585    43634      +49     
  Partials       32       32              
Impacted Files Coverage Δ
...ules/EarthEditor/LayerTreeViewItem/Layer/index.tsx 0.00% <ø> (ø)
src/components/molecules/Visualizer/Engine/ref.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/Plugin/api.ts 6.22% <0.00%> (-0.06%) ⬇️
...rc/components/molecules/Visualizer/Plugin/types.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/hooks.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/storybook.tsx 0.00% <0.00%> (ø)
...components/molecules/Visualizer/Plugin/context.tsx 31.92% <25.00%> (-0.08%) ⬇️
...nents/molecules/Visualizer/Engine/Cesium/common.ts 40.89% <27.27%> (-0.22%) ⬇️
src/util/geolocation.ts 42.85% <42.85%> (ø)
...molecules/Visualizer/Engine/Cesium/useEngineRef.ts 68.29% <50.00%> (-0.23%) ⬇️

@nina992 nina992 marked this pull request as ready for review December 12, 2022 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant