Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite migration support #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vipwner
Copy link

@vipwner vipwner commented Aug 10, 2024

This PR introduces the following changes to migrate the Grunge Stack project from its previous build system to Vite, providing a faster and more modern development experience.

  1. Migration to Vite:

    Configured vite.config.ts:
    Set base to /_static/ for production builds to align with Architect's static file serving.
    Customized build outputs to place assets in build/client and server-side code in build/server, ensuring compatibility with the Architect deployment.

  2. Updated Architect Configuration:

    Adjusted .arc settings to serve static assets from build/client and deploy server-side code from build/server.
    Ensured the deployment process remains smooth by maintaining the existing structure where possible, with the main change being the introduction of Vite.

  3. Maintained Development Workflow:

    Introduced the ability to run arc sandbox and vite dev in parallel during development using concurrently, allowing both the backend (Architect) and frontend (Vite) to work together seamlessly. (I'm still new to Remix and Architect, not sure if this is ok to have it running in parallel - sandbox dynamoDB is needed hence I run it in this way)

  4. Removed Deprecated Plugin:

    Removed the custom plugin that was previously used to notify the Remix dev server of changes, as Vite’s native HMR now handles this automatically.

Open to suggestions :D

@quantuminformation
Copy link

cool, hopefully this can be tested soon

@quantuminformation
Copy link

quantuminformation commented Aug 29, 2024

dang 3 weeks no feedback, might be time to look for a new AWS stack..

anyone tried another one?

@quantuminformation
Copy link

can we decide one way or another if this stack is to be dropped, so I can go with another one for new project

@quantuminformation
Copy link

image maybe SST

@Xiphe
Copy link

Xiphe commented Oct 10, 2024

Thank you for providing this. Really helped me <3

@davidfrtala
Copy link

This PR actually fixes also a recent issue with Architect (here #193)
So for me it's a life saver after trying to spin up the original grunge stack (which is currently broken)

@davidfrtala
Copy link

dang 3 weeks no feedback, might be time to look for a new AWS stack..

anyone tried another one?

I've tried just today and it works flawlessly! From local development to deploying onto AWS!

@davidfrtala
Copy link

@0dayBookworm please, also update remix.init/gitignore template. It rollbacked your changes after I've ran init
image

@quantuminformation
Copy link

quantuminformation commented Oct 10, 2024 via email

const appDir = path.join(process.cwd(), "app");

route(
"__tests/create-user",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0dayBookworm removing this, broke the Cypress testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants