-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vite migration support #188
base: main
Are you sure you want to change the base?
Conversation
cool, hopefully this can be tested soon |
dang 3 weeks no feedback, might be time to look for a new AWS stack.. anyone tried another one? |
can we decide one way or another if this stack is to be dropped, so I can go with another one for new project |
Thank you for providing this. Really helped me <3 |
This PR actually fixes also a recent issue with Architect (here #193) |
I've tried just today and it works flawlessly! From local development to deploying onto AWS! |
I have quite a large existing project. Do you think this would work with
existing installation to aws
…On Thu, 10 Oct 2024 at 16:57, David Frtala ***@***.***> wrote:
@0dayBookworm <https://github.com/0dayBookworm> please, also update
remix.init/gitignore template. It rollbacked your changes after I've ran
init
image.png (view on web)
<https://github.com/user-attachments/assets/25107ee0-dbf4-4e66-91c9-fd04fd5be9c7>
—
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU35SJ7XCOVA524DZEPC3Z22PXZAVCNFSM6AAAAABMKHDOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGUYDCMRTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
const appDir = path.join(process.cwd(), "app"); | ||
|
||
route( | ||
"__tests/create-user", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0dayBookworm removing this, broke the Cypress testing
This PR introduces the following changes to migrate the Grunge Stack project from its previous build system to Vite, providing a faster and more modern development experience.
Migration to Vite:
Configured vite.config.ts:
Set base to /_static/ for production builds to align with Architect's static file serving.
Customized build outputs to place assets in build/client and server-side code in build/server, ensuring compatibility with the Architect deployment.
Updated Architect Configuration:
Adjusted .arc settings to serve static assets from build/client and deploy server-side code from build/server.
Ensured the deployment process remains smooth by maintaining the existing structure where possible, with the main change being the introduction of Vite.
Maintained Development Workflow:
Introduced the ability to run arc sandbox and vite dev in parallel during development using concurrently, allowing both the backend (Architect) and frontend (Vite) to work together seamlessly. (I'm still new to Remix and Architect, not sure if this is ok to have it running in parallel - sandbox dynamoDB is needed hence I run it in this way)
Removed Deprecated Plugin:
Removed the custom plugin that was previously used to notify the Remix dev server of changes, as Vite’s native HMR now handles this automatically.
Open to suggestions :D