Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message if the benchmark operation fails #286

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Print a message if the benchmark operation fails #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5836a
Print a message if the benchmark operation fails
lbulej Jun 21, 2021
6e4f2e0
Print the validation warning using a single call
lbulej Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions renaissance-core/src/main/java/org/renaissance/BenchmarkResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ public static BenchmarkResult dummy(Object... objects) {
return () -> {
Arrays.fill(objects, null);

System.err.println("WARNING: This benchmark provides no result that can be validated.");
System.err.println(" There is no way to check that no silent failure occurred.");
System.err.print(
"WARNING: This benchmark provides no result that can be validated.\n"+
"There is no way to check that no silent failure occurred.\n"
);
};
}

Expand Down
50 changes: 30 additions & 20 deletions renaissance-harness/src/main/java/org/renaissance/harness/ExecutionDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,13 @@ final class ExecutionDriver {
private final ExecutionPolicy executionPolicy;

/** Preformatted message to print before executing the benchmark. */
private final String beforeEachMessageFormat;
private final String beforeEachFormat;

/** Preformatted message to print after executing the benchmark. */
private final String afterEachMessageFormat;
/** Preformatted message to print after successful benchmark operation. */
private final String afterSuccessFormat;

/** Preformatted message to print after failed benchmark operation. */
private final String afterFailureFormat;

/** The value of {@link System#nanoTime()} at VM start. */
private final long vmStartNanos;
Expand All @@ -58,20 +61,17 @@ private ExecutionDriver(

this.benchmarkName = context.benchmarkName();

// Pre-format the before/after messages (escaping the format specifier
// for the operation index which keeps changing) so that we don't have
// to query the static information over and over.
this.beforeEachMessageFormat = String.format(
"====== %s (%s) [%s], iteration %%d started ======\n",
context.benchmarkName(), context.benchmarkPrimaryGroup(),
context.configurationName()
// Pre-format the message prefix so that we don't have to query
// the static information about a benchmark over and over.
String prefix = String.format(
"====== %s (%s) [%s], iteration", context.benchmarkName(),
context.benchmarkPrimaryGroup(), context.configurationName()
);

this.afterEachMessageFormat = String.format(
"====== %s (%s) [%s], iteration %%d completed (%%.3f ms) ======\n",
context.benchmarkName(), context.benchmarkPrimaryGroup(),
context.configurationName()
);
// Add formats for the message parts that change.
this.beforeEachFormat = prefix + " %d started ======\n";
this.afterSuccessFormat = prefix + " %d completed (%.3f ms) ======\n";
this.afterFailureFormat = prefix + " %d failed (%s) ======\n";
}


Expand All @@ -84,17 +84,23 @@ public final void executeBenchmark() throws ValidationException {
try {
eventDispatcher.notifyAfterBenchmarkSetUp(benchmarkName);

int operationIndex = 0;

try {
int operationIndex = 0;
while (executionPolicy.canExecute(benchmarkName, operationIndex)) {
printBeforeEachMessage(operationIndex);

final long durationNanos = executeOperation(operationIndex);

printAfterEachMessage(operationIndex, durationNanos);
printAfterSuccessMessage(operationIndex, durationNanos);
operationIndex++;
}

} catch (Throwable cause) {
// Print failure line with a cause and rethrow the exception.
printAfterFailureMessage(operationIndex, cause.getClass().getSimpleName());
throw cause;

} finally {
// Complement the notifyAfterBenchmarkSetUp() events.
eventDispatcher.notifyBeforeBenchmarkTearDown(benchmarkName);
Expand Down Expand Up @@ -149,15 +155,19 @@ private long executeOperation(final int index) throws ValidationException {


private void printBeforeEachMessage(int index) {
System.out.printf(beforeEachMessageFormat, index);
System.out.printf(beforeEachFormat, index);
}


private void printAfterEachMessage(int index, long nanos) {
private void printAfterSuccessMessage(int index, long nanos) {
final double millis = nanos / 1e6;

// Use root locale to avoid locale-specific float formatting.
System.out.printf(Locale.ROOT, afterEachMessageFormat, index, millis);
System.out.printf(Locale.ROOT, afterSuccessFormat, index, millis);
}

private void printAfterFailureMessage(int index, String cause) {
System.out.printf(afterFailureFormat, index, cause);
}


Expand Down