Update so values like 1 and 1.2 are constraints

renovatebot · Sep 30, 2024 · af86be4 · af86be4
1 parent f11569c
commit af86be4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/modules/versioning/devbox/index.spec.ts b/lib/modules/versioning/devbox/index.spec.ts
@@ -3,17 +3,17 @@ import devbox from '.';
 describe('modules/versioning/devbox/index', () => {
   it.each`
     version           | expected
-    ${'1'}            | ${true}
+    ${'1'}            | ${false}
     ${'01'}           | ${false}
     ${'1.01'}         | ${false}
-    ${'1.1'}          | ${true}
+    ${'1.1'}          | ${false}
     ${'1.3.0'}        | ${true}
     ${'2.1.20'}       | ${true}
     ${'v1.4'}         | ${false}
     ${'V0.5'}         | ${false}
     ${'3.5.0'}        | ${true}
     ${'4.2.21.Final'} | ${false}
-    ${'1234'}         | ${true}
+    ${'1234'}         | ${false}
     ${'foo'}          | ${false}
     ${'latest'}       | ${false}
     ${''}             | ${false}

diff --git a/lib/modules/versioning/devbox/index.ts b/lib/modules/versioning/devbox/index.ts
@@ -8,11 +8,12 @@ export const displayName = 'devbox';
 
 export const supportsRanges = false;
 
-const versionPattern = regEx(/^((\d|[1-9]\d*)(\.(\d|[1-9]\d*)){0,2})$/);
+const validPattern = regEx(/^((\d|[1-9]\d*)(\.(\d|[1-9]\d*)){0,2})$/);
+const versionPattern = regEx(/^((\d|[1-9]\d*)(\.(\d|[1-9]\d*)){2})$/);
 
 class DevboxVersioningApi extends GenericVersioningApi {
   protected _parse(version: string): GenericVersion | null {
-    const matches = versionPattern.exec(version);
+    const matches = validPattern.exec(version);
     if (!matches) {
       return null;
     }
@@ -31,7 +32,8 @@ class DevboxVersioningApi extends GenericVersioningApi {
     if (version === 'latest') {
       return false;
     }
-    return this.isValid(version);
+    const matches = versionPattern.exec(version);
+    return !!matches;
   }
 
   protected override _compare(version: string, other: string): number {