Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(versioning): Add Unity3D #27307

Merged
merged 11 commits into from
Mar 17, 2024
Merged

Conversation

ViMaSter
Copy link
Contributor

@ViMaSter ViMaSter commented Feb 15, 2024

Changes

Adds versioning for updating the runtime of a project using the Unity game engine.

Context

See #27219, implements part of #27295.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ViMaSter ViMaSter changed the title Feat/unity3d manager feat(manager/unity3d): Add Unity3D support Feb 15, 2024
@secustor
Copy link
Collaborator

Please split out manager, versioning and datasource in separate PRs.

@secustor secustor marked this pull request as draft February 17, 2024 23:11
@ViMaSter ViMaSter force-pushed the feat/unity3d-manager branch from 50399f8 to 085d70b Compare February 19, 2024 23:46
@ViMaSter
Copy link
Contributor Author

@secustor The manager depends on the datasource, which in turn depends on the versioning, so I've replaced this PR to only contain the versioning for now. Also rebased it onto the latest main and updated the Pull Request description.

For context: The manager requires the datasource to be present for the supportedDatasources export and the datasource uses the new versioning as defaultVersioning.

Would it be best to create the next PR only after this one is integrated?
As a possible alternative, I can already create the remaining two PRs, but base them on one another instead of main.
Let me know what would be the best approach here! :)

@ViMaSter ViMaSter marked this pull request as ready for review February 19, 2024 23:48
@ViMaSter ViMaSter changed the title feat(manager/unity3d): Add Unity3D support feat(versioning/unity3d): Add Unity3D support Feb 19, 2024
rarkins
rarkins previously approved these changes Feb 20, 2024
@viceice
Copy link
Member

viceice commented Feb 20, 2024

@secustor The manager depends on the datasource, which in turn depends on the versioning, so I've replaced this PR to only contain the versioning for now. Also rebased it onto the latest main and updated the Pull Request description.

For context: The manager requires the datasource to be present for the supportedDatasources export and the datasource uses the new versioning as defaultVersioning.

Would it be best to create the next PR only after this one is integrated?
As a possible alternative, I can already create the remaining two PRs, but base them on one another instead of main.
Let me know what would be the best approach here! :)

you can cascade them. GitHub should automatically change target branch when parent PR gets merged.

@ViMaSter
Copy link
Contributor Author

ViMaSter commented Feb 21, 2024

Thanks for the review and approval!

you can cascade them. GitHub should automatically change target branch when parent PR gets merged.

Hmm, I'm not sure that works. I've created two PRs that are based on each other ViMaSter#6 (datasource into this branch) and ViMaSter#7 (manager into the datasource branch), but as the branches I'm working on are part of a fork, the Pull Requests aren't part of this repository.

I could create them pointing at renovate:main, but at that point the manager PR would be identical to my initial submission.

@rarkins
Copy link
Collaborator

rarkins commented Feb 21, 2024

Needs test passing before we can merge this one

lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title feat(versioning/unity3d): Add Unity3D support feat(versioning): Add Unity3D Feb 21, 2024
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/readme.md Outdated Show resolved Hide resolved
@ViMaSter
Copy link
Contributor Author

Thanks for re-queuing the Actions! I'll resolve the missing test coverage, linter errors and rebase it onto main again, once I'm back from work in around 9 hrs from now.

auto-merge was automatically disabled February 23, 2024 15:04

Head branch was pushed to by a user without write access

@ViMaSter ViMaSter force-pushed the feat/unity3d-manager branch from cadaefe to 8dcc91a Compare February 23, 2024 15:05
@ViMaSter
Copy link
Contributor Author

Rebased the branch and resolved issues with coverage, as one of the regexes was redundant.

Builds look good on my fork: https://github.com/ViMaSter/renovate/actions/runs/8021111410?pr=8

@rarkins rarkins requested review from secustor and rarkins February 23, 2024 16:22
@rarkins rarkins enabled auto-merge February 23, 2024 16:22
auto-merge was automatically disabled February 23, 2024 23:54

Head branch was pushed to by a user without write access

@rarkins rarkins requested review from viceice and secustor February 24, 2024 12:42
secustor
secustor previously approved these changes Feb 24, 2024
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/unity3d/index.ts Outdated Show resolved Hide resolved
@ViMaSter ViMaSter force-pushed the feat/unity3d-manager branch from ecc8ce7 to 00bc918 Compare March 5, 2024 19:22
@ViMaSter ViMaSter requested review from secustor and viceice March 5, 2024 23:05
@secustor secustor enabled auto-merge March 17, 2024 09:49
@secustor secustor added this pull request to the merge queue Mar 17, 2024
Merged via the queue into renovatebot:main with commit 28e0123 Mar 17, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.252.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ViMaSter ViMaSter deleted the feat/unity3d-manager branch March 17, 2024 10:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants