-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(versioning): Add Unity3D #27307
Conversation
Please split out manager, versioning and datasource in separate PRs. |
50399f8
to
085d70b
Compare
@secustor The manager depends on the datasource, which in turn depends on the versioning, so I've replaced this PR to only contain the versioning for now. Also rebased it onto the latest For context: The manager requires the datasource to be present for the Would it be best to create the next PR only after this one is integrated? |
you can cascade them. GitHub should automatically change target branch when parent PR gets merged. |
Thanks for the review and approval!
Hmm, I'm not sure that works. I've created two PRs that are based on each other ViMaSter#6 (datasource into this branch) and ViMaSter#7 (manager into the datasource branch), but as the branches I'm working on are part of a fork, the Pull Requests aren't part of this repository. I could create them pointing at |
Needs test passing before we can merge this one |
Thanks for re-queuing the Actions! I'll resolve the missing test coverage, linter errors and rebase it onto |
Head branch was pushed to by a user without write access
cadaefe
to
8dcc91a
Compare
Rebased the branch and resolved issues with coverage, as one of the regexes was redundant. Builds look good on my fork: https://github.com/ViMaSter/renovate/actions/runs/8021111410?pr=8 |
Head branch was pushed to by a user without write access
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
ecc8ce7
to
00bc918
Compare
🎉 This PR is included in version 37.252.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Adds versioning for updating the runtime of a project using the Unity game engine.
Context
See #27219, implements part of #27295.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: